Closed
Bug 1612424
Opened 5 years ago
Closed 5 years ago
Patch nsis to omit timestamps
Categories
(Firefox Build System :: General: Unsupported Platforms, defect)
Firefox Build System
General: Unsupported Platforms
Tracking
(firefox74 fixed)
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This patch comes from Tor who applies the same thing to their builds. While we don't actually build a functioning installer right now, it is good to keep parity with their toolchain.
|
Assignee | |
Comment 1•5 years ago
|
||
Adding --no-insert-timestamp to APPEND_LINKFLAGS for nsis is not working as it
is used for both the host and cross-compiled parts, but this option is
only valid for the Windows linker. Therefore we add it using a patch
to the cross-compilation part only.
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/087ab18d424e
Patch nsis to call lld with --no-insert-timestamp r=froydnj
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•