Glean pings for `org-mozilla-fenix` contain unusual number of errors under `#/ping_info/experiments/web-render-performance-comparison-experiment/extra`
Categories
(Data Platform and Tools :: General, defect)
Tracking
(Not tracked)
People
(Reporter: amiyaguchi, Assigned: mdroettboom)
References
Details
(Whiteboard: [dataquality])
Attachments
(2 files)
As of 2020-02-03, the schema errors by namespace and document shows that #/ping_info/experiments/web-render-performance-comparison-experiment/extra
is causing rejection for pings under org-mozilla-fenix
at rank 24, 29, 30, 32, and 34 with errors around the 50k mark over the last 28 days.
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
The specific error looks to be:
org.everit.json.schema.ValidationException: #/ping_info/experiments/webrender-performance-comparison-experiment/extra: expected type: JSONObject, found: Null
A relevant snippet of payload JSON is:
"experiments":{"webrender-performance-comparison-experiment":{"branch":"disable_webrender","extra":null}}
So the problem is that the client is explicitly sending "extra":null
where the glean schema does not allow nulls for extra
.
Assignee | ||
Comment 2•5 years ago
|
||
I'll look at this from the point of view of the Glean SDK...
Assignee | ||
Comment 3•5 years ago
|
||
I think this is definitely a bug in Glean SDK. It needs to be updated to leave out extra
when there are no values. However, rolling this out into Fenix will take some time.
I would propose that we allow this in the schema, wait for the fit in Glean SDK to roll out, and then (optionally) disallow it in the schema again.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
(In reply to Michael Droettboom [:mdroettboom] from comment #3)
I think this is definitely a bug in Glean SDK. It needs to be updated to leave out
extra
when there are no values. However, rolling this out into Fenix will take some time.I would propose that we allow this in the schema, wait for the fit in Glean SDK to roll out, and then (optionally) disallow it in the schema again.
Yes, good catch. I agree with the plan!
Comment 7•5 years ago
|
||
We are successfully ingesting some pings from the affected experiment now, as shown by querying the live table:
SELECT
DATE(submission_timestamp) AS submission_date,
COUNT(*) AS n
FROM
`moz-fx-data-shar-nonprod-efed.org_mozilla_fenix_live.baseline_v1`,
UNNEST(ping_info.experiments) AS experiment
WHERE
DATE(submission_timestamp) >= "2020-02-01"
AND experiment.key = 'webrender-performance-comparison-experiment'
GROUP BY
1
Previous days return no rows, but we have 347 pings so far today.
Updated•1 year ago
|
Description
•