Closed Bug 1613039 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 21566 - [webnfc] Fix a bug for mock nfc impl

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21566 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21566
Details from upstream follow.

Leon Han <leon.han@intel.com> wrote:

[webnfc] Fix a bug for mock nfc impl

In js, "enum_value ? x : y;" will get y when enum_value is either null
or 0, but x is what we actually want to get in case of enum_value being
0, so the correct code should be "enum_value != null ? x : y".

BUG=520391

Change-Id: Ibe3771d0dc0ece3cd6659aec298306f694a8f0e8

Reviewed-on: https://chromium-review.googlesource.com/2037106
WPT-Export-Revision: 54dfb7de58c0d695e61e3a4118ac7f2c897ec8d5

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28a46012fe3c [wpt PR 21566] - [webnfc] Fix a bug for mock nfc impl, a=testonly

https://hg.mozilla.org/mozilla-central/rev/28a46012fe3c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.