Closed Bug 1613264 Opened 5 years ago Closed 5 years ago

Double clicking to select the text in the urlbar doesn't work for some completions anymore

Categories

(Firefox :: Address Bar, defect, P1)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
Firefox 74
Iteration:
74.2 - Jan 20 - Feb 09
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- unaffected
firefox74 + fixed

People

(Reporter: jrmuizel, Assigned: mak)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  • Type "goo"
  • This will autocomplete to "google.com" and will suggest "https://google.com/ -- Visit"
  • Double clicking in the urlbar should select all the text but it doesn't. It selects it momentarily and then unselects it.

I did a regression window and found this:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b9ffa67dd4dfb935b4f39010eefd615c6d70fdab&tochange=32f7019f65826f9aab0d36d177064461ed1f9b40

Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(mak)
Keywords: regression

[Tracking Requested - why for this release]: A user noticeable regression

Regressed by: 1601052

Thanks, on focus we open the view and re-run the query, when the query completes we end up resetting the selection and that causes the problem. I'll look into solutions for this.

Assignee: nobody → mak
Status: NEW → ASSIGNED
Flags: needinfo?(mak)
Iteration: --- → 74.2 - Jan 20 - Feb 09

Tested on Windows 10 x64 and Mac 10.14 and only Nightly 74.0a1 (2020-02-04) is affected by the issue. Therefore, will add the according flags.

OS: Unspecified → All
Hardware: Unspecified → Desktop
Priority: -- → P1

It's not just double clicking, even single clicking to move the cursor is broken if the result was autofilled. It's because we used to not requery if the view was open, but tab switch wants to requery regardless. In Bug 1601052 I took the tab switch path and forgot the bring back the isOpen check for the other path.

Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/8b6868dfc7a7 Clicking on urlbar text is misbehaving on autofill. r=adw
Flags: needinfo?(mak)

That looks really suspicious, this is a trivial ui change, are you sure it's related to this push?

Flags: needinfo?(mak) → needinfo?(nbeleuzu)

I guess it must be related to storing the TabSelect event...

Thanks, I'll check on Try if it's the event caching.

Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/e5d555a9991a Clicking on urlbar text is misbehaving on autofill. r=adw
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: