Double clicking to select the text in the urlbar doesn't work for some completions anymore
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox72 | --- | unaffected |
firefox73 | --- | unaffected |
firefox74 | + | fixed |
People
(Reporter: jrmuizel, Assigned: mak)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
STR:
- Type "goo"
- This will autocomplete to "google.com" and will suggest "https://google.com/ -- Visit"
- Double clicking in the urlbar should select all the text but it doesn't. It selects it momentarily and then unselects it.
I did a regression window and found this:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b9ffa67dd4dfb935b4f39010eefd615c6d70fdab&tochange=32f7019f65826f9aab0d36d177064461ed1f9b40
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 1•5 years ago
|
||
[Tracking Requested - why for this release]: A user noticeable regression
Assignee | ||
Comment 2•5 years ago
|
||
Thanks, on focus we open the view and re-run the query, when the query completes we end up resetting the selection and that causes the problem. I'll look into solutions for this.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Tested on Windows 10 x64 and Mac 10.14 and only Nightly 74.0a1 (2020-02-04) is affected by the issue. Therefore, will add the according flags.
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
It's not just double clicking, even single clicking to move the cursor is broken if the result was autofilled. It's because we used to not requery if the view was open, but tab switch wants to requery regardless. In Bug 1601052 I took the tab switch path and forgot the bring back the isOpen check for the other path.
Assignee | ||
Comment 5•5 years ago
|
||
Comment 7•5 years ago
|
||
Backed out for leaks at (AbstractThread, AbstractWatcher, AnimationTimeline, AsyncFreeSnowWhite).
Backout link: https://hg.mozilla.org/integration/autoland/rev/034b35b48e8d71b0cb157f500d05490ca0753e47
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287705214&repo=autoland&lineNumber=12857
Assignee | ||
Comment 8•5 years ago
|
||
That looks really suspicious, this is a trivial ui change, are you sure it's related to this push?
Assignee | ||
Comment 9•5 years ago
|
||
I guess it must be related to storing the TabSelect event...
Comment 10•5 years ago
|
||
:mak , the failures started with this push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&searchStr=os%2Cx%2C10.14%2Cdebug&fromchange=c02a7a545a87e7d519dc8d36113ee05afcd8bde3&tochange=30d70d402f129680a93490db6898d933013b67b3
Assignee | ||
Comment 11•5 years ago
|
||
Thanks, I'll check on Try if it's the event caching.
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•