Closed Bug 1613291 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 21588 - html: Fix assert_array_equals usage in pseudo-classes

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21588 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21588
Details from upstream follow.

Timothy Gu <timothygu99@gmail.com> wrote:

html: Fix assert_array_equals usage in pseudo-classes

document.querySelectorAll returns a NodeList, which does not have a .slice method that assert_array_equals uses. This fixes dir.html on Firefox, which supports the :dir pseudo-class.

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 56 tests

Status Summary

Firefox

OK : 12[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 13[GitHub]
PASS: 71[GitHub] 109[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 18

Chrome

OK : 13
PASS: 75
FAIL: 14

Safari

OK : 13
PASS: 76
FAIL: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/semantics/selectors/pseudo-classes/readwrite-readonly.html
The :read-only pseudo-class must match textarea elements after the readonly attribute has been added: FAIL
The :read-write pseudo-class must not match input elements to which the readonly attribute does not apply: FAIL
The :read-write pseudo-class must match elements that are editable: FAIL
The :read-only pseudo-class must match textarea elements that have a readonly attribute, or that are disabled: FAIL
The :read-write pseudo-class must match textarea elements after the readonly attribute has been added: FAIL
The :read-write pseudo-class must match textarea elements that do not have a readonly attribute, and that are not disabled: FAIL
The :read-only pseudo-class must not match elements that are editable: FAIL

New Tests That Don't Pass

/html/semantics/selectors/pseudo-classes/focus.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/html/semantics/selectors/pseudo-classes/readwrite-readonly.html
The :read-only pseudo-class must not match elements that are editing hosts: FAIL (Chrome: FAIL, Safari: PASS)
The :read-write pseudo-class must not match input elements after the readonly attribute has been added: FAIL (Chrome: FAIL, Safari: PASS)
The :read-only pseudo-class must match input elements after the readonly attribute has been removed: FAIL (Chrome: PASS, Safari: FAIL)
The :read-only pseudo-class must match textarea elements after the readonly attribute has been added: FAIL (Chrome: PASS, Safari: PASS)
The :read-only pseudo-class must match input elements after the readonly attribute has been added: FAIL (Chrome: PASS, Safari: FAIL)
The :read-write pseudo-class must match elements that are editing hosts: FAIL (Chrome: FAIL, Safari: PASS)
The :read-write pseudo-class must not match input elements to which the readonly attribute does not apply: FAIL (Chrome: PASS, Safari: PASS)
The :read-only pseudo-class must match input elements to which the readonly attribute does not apply: FAIL (Chrome: FAIL, Safari: PASS)
The :read-write pseudo-class must match elements that are editable: FAIL (Chrome: PASS, Safari: PASS)
The :read-only pseudo-class must not match input elements to which the readonly attribute applies, and that are mutable: FAIL (Chrome: PASS, Safari: FAIL)
The :read-only pseudo-class must match textarea elements that have a readonly attribute, or that are disabled: FAIL (Chrome: PASS, Safari: PASS)
The :read-write pseudo-class must not match textarea elements that are disabled: FAIL (Chrome: FAIL, Safari: PASS)
The :read-write pseudo-class must match textarea elements after the readonly attribute has been added: FAIL (Chrome: PASS, Safari: PASS)
The :read-write pseudo-class must match textarea elements that do not have a readonly attribute, and that are not disabled: FAIL (Chrome: PASS, Safari: PASS)
The :read-only pseudo-class must match textarea elements that are disabled: FAIL (Chrome: FAIL, Safari: PASS)
The :read-write pseudo-class must not match input elements after the readonly attribute has been removed: FAIL (Chrome: FAIL, Safari: PASS)
The :read-only pseudo-class must not match elements that are editable: FAIL (Chrome: PASS, Safari: PASS)
The :read-write pseudo-class must match input elements to which the readonly attribute applies, and that are mutable: FAIL (Chrome: FAIL, Safari: PASS)

Tests Disabled in Gecko Infrastructure

/html/semantics/selectors/pseudo-classes/focus.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93bfa743b4ca [wpt PR 21588] - html: Fix assert_array_equals usage in pseudo-classes, a=testonly https://hg.mozilla.org/integration/autoland/rev/3ab5e9ef7da1 [wpt PR 21588] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.