[wpt-sync] Sync PR 21598 - Fix outline when linebox has non-zero inline offset
Categories
(Core :: Layout, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 21598 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/21598
Details from upstream follow.
Koji Ishii <kojii@chromium.org> wrote:
Fix outline when linebox has non-zero inline offset
When computing outline rects in an inline formatting context,
the coordinate system needs to be relative to the root of the
inline formatting context, because the algorithm needs to
call |LayoutObject| functions, which uses the coordinate
system for inline |LayoutObject|s.This patch fixes not to accumulate line box offset. For the
inline direction, this is usually zero and is not visible,
but non-zeropadding-leftcan expose this difference.Bug: 1048070
Change-Id: I30dfabcca621136b6d78892a1856c1336c7438eb
Reviewed-on: https://chromium-review.googlesource.com/2038296
WPT-Export-Revision: d67717d5ce1239f89257595ca57e00a2f56e881d
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
FAIL: 1
Chrome
FAIL: 1
Safari
PASS: 1
Links
Details
New Tests That Don't Pass
/css/css-ui/outline-with-padding-001.html: FAIL (Chrome: FAIL, Safari: PASS)
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0ac8824f8782
https://hg.mozilla.org/mozilla-central/rev/904d477bfb8e
Description
•