Closed Bug 1613485 Opened 5 years ago Closed 5 years ago

Add a new COMPOSITE_SWAP_TIME metric

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1613485. Add a new COMPOSITE_SWAP_TIME metric.
(deleted), text/x-phabricator-request
chutten
: data-review-
Details
review.md
(deleted), text/plain
chutten
: data-review+
Details

We want to track how long the actual swap takes. This is an important part of COMPOSITE_TIME and we want to see how it moves separately.

Depends on: 1612511
Blocks: wr-perf-tools
Priority: -- → P3
Summary: Add a new COMPOSITE_END_FRAME metric → Add a new COMPOSITE_SWAP_TIME metric
Blocks: 1612511
No longer depends on: 1612511

This should help us narrow down the regression in COMPOSITE_TIME

Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED

Comment on attachment 9124816 [details]
Bug 1613485. Add a new COMPOSITE_SWAP_TIME metric.

  1. What questions will you answer with this data?

The causes of COMPOSITE_TIME regressions

  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:

As we change graphics we've seen regressions in COMPOSITE_TIME. This splits out a part of COMPOSITE_TIME so that we can better understand where the time is going.

  1. Can current instrumentation answer these questions?

Nope.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #

  1. How long will this data be collected? Choose one of the following:

    I want to permanently monitor this data. jrmuizel

  2. What populations will you measure?

All

  1. Which release channels?

All
7. Which countries?

All
8. Which locales?
All

  1. Any other filters? Please describe in detail below.
    All

  2. If this data collection is default on, what is the opt-out mechanism for users?

Regular opt-out

  1. Please provide a general description of how you will analyze this data.

Regular telemetry analysis

  1. Where do you intend to share the results of your analysis?

On bugzilla

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? If so:

Nope
14. Are you using that on the Mozilla backend? Or going directly to the third-party?

Yep

Attachment #9124816 - Flags: data-review?(chutten)

Comment on attachment 9124816 [details]
Bug 1613485. Add a new COMPOSITE_SWAP_TIME metric.

I'm afraid this'll be data-review- for the moment as it seems as though the answer to Q4 has been omitted. Everything else seems to be present and correct, though.

Oh, and while I'm here: please file data review requests as bug attachments. They fit better into Data Stewardship's workflow that way.

Attachment #9124816 - Flags: data-review?(chutten) → data-review-
Attached file review.md (deleted) —
Attachment #9125092 - Flags: data-review?(chutten)
Comment on attachment 9125092 [details] review.md DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? Yes, jrmuizel is responsible. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? No. This collection is permanent. --- Result: datareview+
Attachment #9125092 - Flags: data-review?(chutten) → data-review+
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/14dbcf5cc779 Add a new COMPOSITE_SWAP_TIME metric. r=aosmond

https://hg.mozilla.org/mozilla-central/rev/14dbcf5cc779

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: