Closed Bug 1613771 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 21644 - Use error instead of critical for logging the traceback (#21594)

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21644 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21644
Details from upstream follow.

Carlos Alberto Lopez Perez <clopez@igalia.com> wrote:

Use error instead of critical for logging the traceback (#21594)

If critical its used, then the test step will return non-zero status,
even when the step has finished completing the run.
This causes issues on the CI, as the whole run its marked as failed
even when it completed.
This fixes issue #21594

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/68cf85b8381f [wpt PR 21644] - Use error instead of critical for logging the traceback (#21594), a=testonly

https://hg.mozilla.org/mozilla-central/rev/68cf85b8381f

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.