Closed Bug 1614845 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 21744 - Revert "[Shape Detection] Use IDL dictionaries for result types"

Categories

(Core :: Storage: IndexedDB, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21744 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21744
Details from upstream follow.

Kristi Park <kristipark@chromium.org> wrote:

Revert "[Shape Detection] Use IDL dictionaries for result types"

This reverts commit bae2a7ee57bb5f420d4450234b904425310d303e.

Reason for revert: Suspect for failing webkit_layout_tests on (none)
GPU on Mac
https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/51385

Original change's description:

[Shape Detection] Use IDL dictionaries for result types

This change updates the DetectedBarcode, DetectedFace and DetectedText
types to be dictionaries rather than interfaces. This is okay because
they have only attributes and no methods. This reduces the amount of
manually written code necessary to implement them.

This enables implementing a new field for issue 1023177 without having
to update the manual serialization and deserialization routines.

Spec PR: https://github.com/WICG/shape-detection-api/pull/86

Bug: 1023177
Change-Id: I3b93d1869c5457e2ce3da5b5690a5ff968a3c77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040378
Auto-Submit: Reilly Grant \<reillyg@chromium.org>
Reviewed-by: Victor Costan \<pwnall@chromium.org>
Reviewed-by: Yuki Shiino \<yukishiino@chromium.org>
Reviewed-by: Kentaro Hara \<haraken@chromium.org>
Commit-Queue: Reilly Grant \<reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740356}

TBR=yukishiino@chromium.org,jbroman@chromium.org,reillyg@chromium.org,haraken@chromium.org,pwnall@chromium.org

Change-Id: Ib2075266871bdae5651e684ac652617de91e2bb2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1023177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049945
Reviewed-by: Kristi Park \<kristipark@chromium.org>
Commit-Queue: Kristi Park \<kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740493}

PR 21744 applied with additional changes from upstream: a4f09b650d25c865045f29fb3f86b428616b2e45, 23ee655e646454469a5ee0ca2758fa8544053ca7
Component: web-platform-tests → Storage: IndexedDB
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 20 subtests

Status Summary

Firefox

ERROR: 12

Chrome

OK : 12
PASS : 237

Safari

ERROR: 12

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/IndexedDB/structured-clone.any.html?1-20: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.html?101-last: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.html?81-100: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.worker.html?101-last: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.html?21-40: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.worker.html?1-20: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.worker.html?21-40: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.html?41-60: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.worker.html?41-60: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.html?61-80: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.worker.html?81-100: ERROR (Chrome: OK, Safari: ERROR)
/IndexedDB/structured-clone.any.worker.html?61-80: ERROR (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88ec5299c1f1 [wpt PR 21744] - Revert "[Shape Detection] Use IDL dictionaries for result types", a=testonly https://hg.mozilla.org/integration/autoland/rev/5154d76a4144 [wpt PR 21744] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.