[Fission] non-Windows ProxyAccessible::ChildAtPoint needs to cross process boundaries into OOP iframes
Categories
(Core :: Disability Access APIs, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: eeejay, Assigned: Jamie)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Currently, the proxy accessible will only query its own DocAccessibleChild for the deepest child. We need to allow proxies to dig into child documents as well.
Assignee | ||
Comment 1•5 years ago
|
||
It just occurred to me: won't this be broken for any iframe, not just Fission iframes?
- Does Accessible::ChildAtPoint traverse into in-process subdocuments? If not, it'll stop at the iframe OuterDoc.
- Even if it does, it'll return an id from the iframe document. ProxyAccessible will then try to use its own DocAccessibleParent... but it'll be the wrong document.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
(In reply to James Teh [:Jamie] from comment #1)
- Does Accessible::ChildAtPoint traverse into in-process subdocuments?
- Even if it does, it'll return an id from the iframe document. ProxyAccessible will then try to use its own DocAccessibleParent... but it'll be the wrong document.
I wonder if PDocAccessible::AccessibleAtPoint can return a PDocAccessible as well as an id? That will fix the e10s case, but we'll still need code in ProxyAccessible to deal with the recursion for the Fission case.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Accessible::ChildAtPoint can return an Accessible in a descendant document.
Thus, we must return the result PDocAccessible via IPC, not just the id.
Previously, we only returned the id, but we'd fail when we tried to look it up if it belonged to a descendant document.
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
When we hit an OOP iframe, we must walk into the child document and continue the search from there.
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0f241c48730c
https://hg.mozilla.org/mozilla-central/rev/4615751fc827
Assignee | ||
Comment 7•5 years ago
|
||
Eitan, you should hopefully now be able to hit test on both normal (in-process) and Fission (out-of-process) iframes on Mac. Would you be able to test and let me know if it works? Thanks.
Reporter | ||
Comment 8•5 years ago
|
||
Tested with Accessibility Inspector on Nightly on OSX. Hittesting works inside of embedded youtube videos.
Thanks!
Description
•