Closed
Bug 1614987
Opened 5 years ago
Closed 5 years ago
Refactor the Moments messages code path into its own hub
Categories
(Firefox :: Messaging System, task, P1)
Firefox
Messaging System
Tracking
()
Tracking | Status | |
---|---|---|
firefox75 | --- | verified |
People
(Reporter: andreio, Assigned: andreio)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/plain
|
chutten
:
data-review+
|
Details |
Currently handled through the ToolbarBadgeHub.
What we want to to achieve:
- add telemetry
- stop continuously checking/setting the pref
- untangle from the badge code
Assignee | ||
Updated•5 years ago
|
Summary: Refactor the Moments messages code path into it's own hub → Refactor the Moments messages code path into its own hub
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → andrei.br92
Iteration: --- → 75.1 - Feb 10 - Feb 23
Priority: -- → P1
Target Milestone: --- → Firefox 75
Updated•5 years ago
|
Iteration: 75.1 - Feb 10 - Feb 23 → 75.2 - Feb 24 - Mar 8
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Attachment #9128898 -
Attachment is obsolete: true
Assignee | ||
Updated•5 years ago
|
Attachment #9129131 -
Flags: data-review?(chutten)
Comment 5•5 years ago
|
||
Comment on attachment 9129131 [details]
data_review_request_moments_page.txt
DATA COLLECTION REVIEW RESPONSE:
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes. This collection is documented in [activity stream's documentation](https://github.com/mozilla/activity-stream/blob/master/docs/v2-system-addon/data_events.md).
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes. This collection is can be controlled through Firefox's Preferences or Activity Stream's settings.
If the request is for permanent data collection, is there someone who will monitor the data over time?
Yes, Nan Jiang is responsible.
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 2, Interaction. (The request is for Cat3 but the only new collection here is of the new event. The client/impression is included by other collections)
Is the data collection request for default-on or default-off?
Default on for all channels.
Does the instrumentation include the addition of any new identifiers?
No.
Is the data collection covered by the existing Firefox privacy notice?
Yes.
Does there need to be a check-in in the future to determine whether to renew the data?
No. This collection is permanent.
---
Result: datareview+
Attachment #9129131 -
Flags: data-review?(chutten) → data-review+
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/969d644dc75b
Refactor the Moments messages code path into its own hub r=k88hudson,nanj
Comment 7•5 years ago
|
||
bugherder |
Comment 8•5 years ago
|
||
I have verified that the "Moments" page is successfully displayed using the following steps:
[Prerequisites]:
- Have the following prefs in the "about:config" page:
- "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" set to "true";
- "browser.newtabpage.activity-stream.asrouter.providers.panel_local_testing" set to "{"id":"panel_local_testing", "cohort": "SHOW_TEST"}";
[Steps to reproduce]:
- Open the browser with the profile from prerequisites.
- Restart the browser and navigate to the "about:config" page.
- Verify that the value of the "browser.startup.homepage_override.once" pref is set.
- Restart the browser.
Verified using the latest Firefox Nightly (75.0a1 Build ID - 20200302094818) installed on Windows 10 x64, Mac 10.15.2, and Ubuntu 18.04 x64.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•