Closed Bug 1614988 Opened 5 years ago Closed 4 years ago

COOP+COEP data URL tests timing out

Categories

(Core :: DOM: Workers, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: annevk, Assigned: valentin)

References

Details

Attachments

(1 file)

I haven't landed these yet (and maybe I should make some more readability tweaks) but https://github.com/web-platform-tests/wpt/pull/21146 has tests that are timing out in Fx Nightly. The blob ones all work, but the data ones do not (both dedicated worker and frame).

Component: DOM: Core & HTML → DOM: Workers
Priority: -- → P2

Can you take this?

Flags: needinfo?(valentin.gosu)
Assignee: nobody → valentin.gosu
Flags: needinfo?(valentin.gosu)

Hi Anne, it's not clear to me why the data URL tests don't work, but it looks like they time out in all browsers according to wpt.fyi
Am I reading this correctly?

Flags: needinfo?(annevk)

Now Chrome implements COEP it revealed a bug in the test that I addressed in https://github.com/web-platform-tests/wpt/pull/22928. With that fix Chrome once again finds all 18 tests (and fails a couple trivial ones), but Firefox continues to time out.

Flags: needinfo?(annevk)
Blocks: 1631748
Blocks: 1631751

The serialization of data URLs in firefox strips newlines from the string,
so the comments end up being on the same line with actual code.
This patch turns them into /* C style comments */

It also seems that the harness sometimes times out, even if all tests pass.

Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c0c878881c86
Make data: tests in blob-data.https.html run r=annevk
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23535 for changes under testing/web-platform/tests
Flags: needinfo?(valentin.gosu)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Flags: needinfo?(valentin.gosu)
Upstream PR merged by jgraham
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: