Don't ship DirectComposition in the places where Chrome blocks it
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details |
See disable_direct_composition in https://cs.chromium.org/chromium/src/gpu/config/gpu_driver_bug_list.json
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Comment on attachment 9129197 [details]
Bug 1615420. Disable DirectComposition in more situations.
Beta/Release Uplift Approval Request
- User impact if declined: DirectComposition might be used in situations where it is buggy
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is pretty low risk. It just disables DirectComposition in a bunch of configurations to minimize initial shipping risk
- String changes made/needed:
Comment 3•5 years ago
|
||
Comment on attachment 9129197 [details]
Bug 1615420. Disable DirectComposition in more situations.
Uplift approved for 74 beta 9, thanks.
Comment 4•5 years ago
|
||
bugherder uplift |
Assignee | ||
Comment 5•5 years ago
|
||
We need to land something like this in 75
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
This is similar to a change that landed directly into 74. We don't want to
roll-out to these users yet and we don't want to have to think about it every
release.
Assignee | ||
Comment 9•5 years ago
|
||
Comment on attachment 9132649 [details]
Bug 1615420. Disable DirectComposition on AMD and older Intel drivers on beta & release.
Beta/Release Uplift Approval Request
- User impact if declined: Higher risk that shipping DirectComposition will break things
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It just minimize the initial roll-out of DirectComposition. We don't know of any actual problems that it prevents.
- String changes made/needed:
Assignee | ||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
bugherder |
Comment 11•5 years ago
|
||
Comment on attachment 9129197 [details]
Bug 1615420. Disable DirectComposition in more situations.
approved for 75.0b5
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Comment on attachment 9129197 [details]
Bug 1615420. Disable DirectComposition in more situations.
Actually do we need both patches here? (one landed on 74, the other on 76)
They seem to conflict.
Assignee | ||
Comment 13•5 years ago
|
||
No, only https://phabricator.services.mozilla.com/D66453/ needs to land.
Updated•5 years ago
|
Comment 14•5 years ago
|
||
bugherder uplift |
Description
•