The UI in a Calendar or Task tab is broken if that tab is focused on startup
Categories
(Calendar :: General, defect)
Tracking
(Not tracked)
People
(Reporter: pmorris, Assigned: pmorris)
References
(Regression)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
darktrojan
:
review+
darktrojan
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
If you close and re-open the tab everything is fine. If you switch to another tab and then back, things are fine except for the tab's icon and title in the tab bar.
Looking closer, this is caused by a load order issue where TodayPane.updateDisplay
gets called before TodayPane.onLoad
, and so TodayPane.paneViews
is still null.
The attached patch improves things but does not fully solve them. With the patch only the left hand sidebar (with the minimonth etc.) is blank rather than the whole tab's UI being off.
I've looked briefly at an approach of calling TodayPane.onLoad
if needed when TodayPane.updateDisplay
is called, but onLoad
is async and updateDisplay
is not. So you end up having a domino effect of switching functions from sync to async.
I also tried calling ltnOnLoad
near the top of OnLoadMessenger
, but that did not fix the problem.
Assignee | ||
Comment 1•4 years ago
|
||
This fixes the problem by loading the calendar component right before any tabs are restored.
Try run just started: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8363172ebded7dff562e1610b6708a6c773187c9
Assignee | ||
Comment 2•4 years ago
|
||
Try run looks good. The linting error is not from this patch (as you can see here).
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c43ae2963d75
Fix calendar tabs when they are focused at startup. r=darktrojan
Updated•4 years ago
|
Comment 4•4 years ago
|
||
bugherder uplift |
Thunderbird 74.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/a376c45565b7
Updated•4 years ago
|
Description
•