Remove optimization tracking code from the profiler
Categories
(Core :: Gecko Profiler, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: jandem, Assigned: canova)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We're removing the JS engine code in bug 1614622, but there's also code elsewhere we can remove or clean up:
|
||
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
This code no longer exists. It looks like it was removed as part of bug 1668219.
|
||
Comment 2•2 years ago
|
||
I think we still have related code in the profiler, I think this is what [this field][https://searchfox.org/mozilla-central/rev/43cb6eca1c3069d46d589d52ab4949257e630d19/tools/profiler/core/ProfiledThreadData.cpp#69) is about. It's difficult for me to follow the C++ code where we'd actually write a value. Nazim, can you please have a look and file another bug if needed?
|
Assignee | |
Comment 3•2 years ago
|
||
Yes, it looks like we still have some code left on the profiler backend side. Let's reopen this so we can cleanup that part. Currently we output all null values for the optimizations on frameTable which is not ideal.
|
|
Assignee | |
Comment 4•2 years ago
|
||
This requires https://github.com/firefox-devtools/profiler/pull/4432 to be
landed and deployed. We bump the profile version in this patch.
Afaik we never used the optimizations field of the frame table in the profiler
frontend and this pfield was null for more than 3 years (since Bug 1614622).
We don't have any plans to make use of it any time soon. It's good to cleanup
this field so it doesn't clutter the profile data and we can reduce the profile
data size.
|
||
Updated•2 years ago
|
Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a78559e1f67b Remove the optimizations field from profiler frame table r=julienw
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Description
•