Closed Bug 1615907 Opened 5 years ago Closed 5 years ago

Global search box should have a blue focus border when focused

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird74 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 75.0
Tracking Flags:
Tracking Status
thunderbird74 --- fixed

People

(Reporter: thomas8, Assigned: Paenglab)

References

(Depends on 1 open bug)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

1615907-searchBox-focus.patch
(deleted), patch
aleca
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review

STR

  1. main 3 pane, click to focus Global Search input box ("Search...")
  2. for comparison, click to focus Quick Filter input box ("Filter these messages...")

Actual

  1. global search box has cursor, but no other visual indication of focus (this bug)
  2. Quick filter box has cursor and blue border around the input box

Expected

  1. global search input should have blue border when focused, same as quick filter

Also, whilst the 1px blue border is very elegant, it's pretty hard to spot. Maybe it doesn't have to be as striking as the current focus in account-settings-Auto-BCC-input (2px focus border, 2px light-blue shadow), but some middle ground between the two extremes would be good, e.g. complementing the 1px solid focus border with some sort of lighter shadow which emphasises where the focus is. A clear indication of focus is definitely helpful between dozens of elements on the screen.

Richard, whilst we are here, please add a bit of padding on the left side of the global search input.

Attached patch 1615907-searchBox-focus.patch (obsolete) (deleted) — — Splinter Review

This is a leftover of bug 1542720 which only changed the shared CSS part.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9126982 - Flags: review?(alessandro)
Attachment #9126982 - Flags: approval-comm-beta?
Comment on attachment 9126982 [details] [diff] [review] 1615907-searchBox-focus.patch Review of attachment 9126982 [details] [diff] [review]: ----------------------------------------------------------------- This makes the main search box highlight with the blue border, but breaks the quick filter search box. The quick filter search box is still a XUL element which handles focus with the `focused="true"` attribute. ::: mail/themes/linux/mail/searchBox.css @@ +38,5 @@ > padding: 3px; > margin: 0 3px; > } > > +.searchBox:focus, The quick filter search is still an XUL element generated by in a CE, so it should stay `[focused="true"]`
Attachment #9126982 - Flags: review?(alessandro) → review-
Attached patch 1615907-searchBox-focus.patch (deleted) — — Splinter Review

Yes sorry, was too enthusiastic to change all. Now this works with all searchboxes. I fixed also that focus has precedence to hover.

Attachment #9126982 - Attachment is obsolete: true
Attachment #9126982 - Flags: approval-comm-beta?
Attachment #9127206 - Flags: review?(alessandro)
Attachment #9127206 - Flags: approval-comm-beta?
Comment on attachment 9127206 [details] [diff] [review] 1615907-searchBox-focus.patch Review of attachment 9127206 [details] [diff] [review]: ----------------------------------------------------------------- Awesome, thank you so much! r+
Attachment #9127206 - Flags: review?(alessandro) → review+
Keywords: checkin-needed-tb

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/aeb27fcae525
Fix the searchbox focus with the default theme. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 75.0
Depends on: 1542720
OS: Windows XP → All
Attachment #9127206 - Flags: approval-comm-beta? → approval-comm-beta+
Component: Mail Window Front End → Theme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: