Closed Bug 1616290 Opened 5 years ago Closed 5 years ago

Inconsistent naming of the "Exit fullscreen" touch bar button

Categories

(Core :: Widget: Cocoa, defect, P2)

Product:
Core
Component:
Widget: Cocoa
Version:
74 Branch
Platform:
Desktop
macOS
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla75
Iteration:
75.2 - Feb 24 - Mar 8
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 --- wontfix
firefox75 --- verified

People

(Reporter: noni, Assigned: bugzilla)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1616290 - Fix the inconsistent naming of the "Exit fullscreen" Touch Bar button. r?mikedeboer
(deleted), text/x-phabricator-request
Details

[Affected versions]:

  • 74.0b4

[Affected platforms]:

  • macOS 10.15.3

[Steps to reproduce]:

  1. Open Firefox.
  2. Navigate to youtube and play any video in fullscreeen.
  3. Observe the "Exit fullscreen" button on the touch bar.
  4. Exit fullscreen.
  5. Enter fullscreen again and observe the button.

[Expected result]:

  • The button is named "Exit fullscreen" each end every time a user enters fullscreen videos.

[Actual result]:

  • The button is called "Search or enter address" after entering fullscreen starting with the second time.

[Regression range]:

[Additional notes]:

  • Even though the button is renamed, the functionality is the expected/desired one, of exiting fullscreen.
Regressed by: 1603321
Has Regression Range: --- → yes
Blocks: touchbar

The localized string "Search or enter address" was being cached and reused for the exit fullscreen button. We should clear that string from the cache before changing the label on the button.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 75.2 - Feb 24 - Mar 8
Points: --- → 1

The priority flag is not set for this bug.
:spohl, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(spohl.mozilla.bugs)
Flags: needinfo?(spohl.mozilla.bugs)
Priority: -- → P2
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ecaaf0731e1 Fix the inconsistent naming of the "Exit fullscreen" Touch Bar button. r=mikedeboer

https://hg.mozilla.org/mozilla-central/rev/6ecaaf0731e1

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Flags: qe-verify+

Verified with 76.0a1 (2020-03-25) and 75.0b8 on macOS 10.15.3.

Status: RESOLVED → VERIFIED
status-firefox75: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: