Open Bug 1616512 Opened 5 years ago Updated 1 year ago

Reps visual polish: indent guide, selected row

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: fvsch, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Attached image reps-visual-tweaks.png (deleted) —

Some possible improvements:

  • Small border-radius for focused rows
  • Shift arrow a bit to the right? Currently it's overflowing a bit from focused rows, but the current alignment might be necessary in Debugger's SecondaryPanes?
  • Arrow vertical alignment: hard to get right, it's shifted with a margin-top: -1px which is ignored on 1x displays.
  • The indent guide could use the same colors as the indent guide in Inspector's Markup view:
.theme-light {
  --markup-outline: var(--theme-splitter-color); /* light gray */
}
.theme-dark {
  --markup-outline: var(--theme-selection-background); /* dark blue */
}
Blocks: dbg-frontend
Keywords: good-first-bug
Priority: -- → P3

Hi! I would like to contribute to this project, can I work on this?

Yes, please!

Assigned to you.

Honza

Assignee: nobody → momo.a.jan
Status: NEW → ASSIGNED

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: momo.a.jan → nobody
Status: ASSIGNED → NEW

Hi @Honza Can I get this please

Solved this bug
Can I submit the patch?

Sure assigned to you.

Assignee: nobody → holaszyd1
Whiteboard: dt-outreachy-2021

Hello bomsy

Here is a first try at fixing this, Please let me know if there is anything to add or modify

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: holaszyd1 → nobody
Severity: normal → S3
Whiteboard: dt-outreachy-2021

Hi there,

I see there is some work on this bug. Can i take it over and use the existing code to get this wrapped up?

Thanks,
Samuel

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: