Use py3_action for GENERATED_FILES that already work in py3
Categories
(Firefox Build System :: General, task)
Tracking
(firefox75 fixed)
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: mshal, Assigned: mshal)
References
Details
Attachments
(2 files)
Bug 1611326 now allows us to use py3_action for GENERATED_FILES, but didn't start to use py3 for anything. We can enable py3 for scripts that already work with it (roughly half).
Assignee | ||
Comment 1•5 years ago
|
||
Without PYTHON3 defined, we can't actually run any GENERATED_FILES
scripts in the fastermake backend.
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D63437
Assignee | ||
Comment 3•5 years ago
|
||
We may get another round of easy wins after bug 1613263 sticks, too. At least generate_bookmarks.py falls into that category.
Comment 5•5 years ago
|
||
Backed out for Android (Bgv) bustage.
backout: https://hg.mozilla.org/integration/autoland/rev/02795141211466d3d07aacde5f8ced4073631120
failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289735832&repo=autoland&lineNumber=1574
[task 2020-02-20T19:13:45.253Z] 19:13:45 INFO - Disallowed: Path "chrome/toolkit/featuregates/feature_definitions.json" has architecture-specific versions:
[task 2020-02-20T19:13:45.253Z] 19:13:45 INFO - arm64-v8a -> 0b5d8d7494aca26561817c691098b75913fc591e
[task 2020-02-20T19:13:45.253Z] 19:13:45 INFO - armeabi-v7a -> fcbddc7649cec509f3ca97d100e9b78420584f7a
[task 2020-02-20T19:13:45.253Z] 19:13:45 INFO - x86 -> 44ea677cd8679e0e4bfe5fb8212e2248073d4ac4
[task 2020-02-20T19:13:45.253Z] 19:13:45 INFO - x86_64 -> b0907db0ed1b1568e0e2183953f323772b0a6088
[task 2020-02-20T19:13:45.254Z] 19:13:45 INFO - Makefile:150: recipe for target 'recurse_android-fat-aar-artifact' failed
[task 2020-02-20T19:13:45.254Z] 19:13:45 ERROR - make[3]: *** [recurse_android-fat-aar-artifact] Error 1
[task 2020-02-20T19:13:45.254Z] 19:13:45 INFO - make[3]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2020-02-20T19:13:45.254Z] 19:13:45 INFO - /builds/worker/workspace/build/src/config/recurse.mk:32: recipe for target 'android-fat-aar-artifact' failed
[task 2020-02-20T19:13:45.254Z] 19:13:45 ERROR - make[2]: *** [android-fat-aar-artifact] Error 2
[task 2020-02-20T19:13:45.254Z] 19:13:45 INFO - /builds/worker/workspace/build/src/config/rules.mk:394: recipe for target 'default' failed
[task 2020-02-20T19:13:45.254Z] 19:13:45 ERROR - make[1]: *** [default] Error 2
[task 2020-02-20T19:13:45.254Z] 19:13:45 INFO - client.mk:125: recipe for target 'build' failed
[task 2020-02-20T19:13:45.254Z] 19:13:45 INFO - make: *** [build] Error 2
[task 2020-02-20T19:13:45.300Z] 19:13:45 INFO - 0 compiler warnings present.
[task 2020-02-20T19:13:45.364Z] 19:13:45 ERROR - Return code: 2
[task 2020-02-20T19:13:45.364Z] 19:13:45 WARNING - setting return code to 2
[task 2020-02-20T19:13:45.364Z] 19:13:45 FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2020-02-20T19:13:45.364Z] 19:13:45 FATAL - Running post_fatal callback...
[task 2020-02-20T19:13:45.364Z] 19:13:45 FATAL - Exiting -1
Assignee | ||
Comment 6•5 years ago
|
||
It looks like py3 writes out the feature_definitions.json file in a random order, which is causing the allow check to fail. I'll leave that as py2 for now.
:nalexander, do you know if there a reason we don't want Bgv builds to run on 'try -p all'? This is the 2nd time I've hit an issue that is green everywhere except this particular build, which I didn't notice because it doesn't run on -p all.
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/38324526e578
https://hg.mozilla.org/mozilla-central/rev/730261800398
Comment 9•5 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #6)
It looks like py3 writes out the feature_definitions.json file in a random order, which is causing the allow check to fail. I'll leave that as py2 for now.
:nalexander, do you know if there a reason we don't want Bgv builds to run on 'try -p all'? This is the 2nd time I've hit an issue that is green everywhere except this particular build, which I didn't notice because it doesn't run on -p all.
No. I'm sure that it was just because GV-builds were a thing built off to the side, and then became the mainline, and whatever the "include in all" flag wasn't flipped. Please flip it!
Description
•