Closed
Bug 1616800
Opened 5 years ago
Closed 5 years ago
MediaControl: MediaControlKeysManager does not honor Open() return value
Categories
(Core :: Audio/Video, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: MeFisto94, Assigned: MeFisto94)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
See https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289625492&repo=autoland&lineNumber=35813 for the failure.
Specifically:
if (mEventSource && !mEventSource->IsOpened()) {
LOG("StartMonitoringControlKeys");
mEventSource->Open();
mEventSource->SetPlaybackState(mPlaybackState);
mEventSource->AddListener(this);
}
The return value of Open() is ignored, however Open() fails on Windows 7 and below.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by marc.streckfuss@gmail.com: https://hg.mozilla.org/integration/autoland/rev/af8c6e426074 MediaControl: MediaControlKeysManager now checks the result of EventSource#Open(). r=alwu
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•