Drop shadows are rendered incorrectly if content is partially clipped
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: cbrewster, Assigned: nical)
References
Details
Attachments
(3 files)
If the original content is clipped for some reason, the drop-shadow for it is not rendered correctly.
Comment 1•5 years ago
|
||
The priority flag is not set for this bug.
:jbonisteel, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Connor - do you think this is a regression? If so, can you find a regression window?
Reporter | ||
Comment 3•5 years ago
|
||
I don't believe this is a regression, I tested with WR from ~2 years ago and it has the same issue.
We probably need to do something along the lines of the todo here: https://searchfox.org/mozilla-central/rev/278046367dab878316f60f0bd7f740cf73f3c447/gfx/wr/webrender/src/picture.rs#4683-4684
Comment 4•5 years ago
|
||
I managed to get a regression range on this issue but its not very accurate though since I got the Not enough data to bisect message.
Last Known GOOD:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf3951daded0b4fefd0fc81ee22ce5d536df2099&tochange=e92ff56d2be21676b447c6fbb87b4c4479539bc9
First Known BAD:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=57c4b2afc95bfb3c444c732802d99c8522414a1b&tochange=e92ff56d2be21676b447c6fbb87b4c4479539bc9
Updated•5 years ago
|
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Nical, do you have a feeling about how to fix this?
Assignee | ||
Comment 6•5 years ago
|
||
We probably need to do something along the lines of the todo here: https://searchfox.org/mozilla-central/rev/278046367dab878316f60f0bd7f740cf73f3c447/gfx/wr/webrender/src/picture.rs#4683-4684
I think that Connor's suggestion makes sense. The reason this was left as a TODO and not just fixed along with whatever the comment came with probably is that there was some trickiness involved but I don't remember very well. I'll have a look when we are confident with the work blocking shipping more intel GPUs.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Depends on D68230
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
bugherder |
Description
•