[rust] Reformat the tree using rustfmt
Categories
(Developer Infrastructure :: Lint and Formatting, task, P2)
Tracking
(Not tracked)
People
(Reporter: Sylvestre, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: leave-open)
Attachments
(56 files, 11 obsolete files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
mach lint -l rustfmt --fix works well, it is enabled at review phase and we have tests in the CI. Let's see how to do it!
The patch is only 1.4M. As comparison, the move to the Google Coding style was 177M
Reporter | ||
Comment 1•5 years ago
|
||
Reformatting the whole tree takes less than ~15s
Reporter | ||
Comment 2•5 years ago
|
||
Reporter | ||
Comment 3•5 years ago
|
||
ignore-this-changeset
Depends on D63758
Reporter | ||
Comment 4•5 years ago
|
||
Reporter | ||
Comment 5•5 years ago
|
||
Reporter | ||
Comment 6•5 years ago
|
||
Depends on D63952
Reporter | ||
Comment 7•5 years ago
|
||
Depends on D63955
Reporter | ||
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
bugherder |
Comment 12•5 years ago
|
||
bugherder |
Comment 13•5 years ago
|
||
Reporter | ||
Comment 14•5 years ago
|
||
Updated audioipc directly upstream:
https://github.com/djg/audioipc-2/pull/91/commits/b1497b9c7d39b49bd85ed5cb751d93b0935e633c
Updated•5 years ago
|
Comment 15•5 years ago
|
||
bugherder |
Reporter | ||
Comment 16•5 years ago
|
||
Reporter | ||
Comment 17•5 years ago
|
||
Depends on D64869
Reporter | ||
Comment 18•5 years ago
|
||
Depends on D64870
Reporter | ||
Comment 19•5 years ago
|
||
Depends on D64871
Reporter | ||
Comment 20•5 years ago
|
||
Depends on D64873
Reporter | ||
Comment 21•5 years ago
|
||
Depends on D64874
Reporter | ||
Comment 22•5 years ago
|
||
Depends on D64875
Comment 23•5 years ago
|
||
Reporter | ||
Comment 24•5 years ago
|
||
Depends on D64875
Comment 25•5 years ago
|
||
bugherder |
Comment 26•5 years ago
|
||
Comment 27•5 years ago
|
||
Updated•5 years ago
|
Comment 28•5 years ago
|
||
Comment 29•5 years ago
|
||
Comment 30•5 years ago
|
||
Comment 31•5 years ago
|
||
bugherder |
Comment 32•5 years ago
|
||
bugherder |
Comment 33•5 years ago
|
||
Comment 34•5 years ago
|
||
bugherder |
Comment 35•5 years ago
|
||
Comment 36•5 years ago
|
||
bugherder |
Reporter | ||
Comment 37•5 years ago
|
||
Reporter | ||
Comment 38•5 years ago
|
||
Depends on D65897
Reporter | ||
Comment 39•5 years ago
|
||
Depends on D65901
Reporter | ||
Comment 40•5 years ago
|
||
Depends on D65902
Comment 41•5 years ago
|
||
Comment 42•5 years ago
|
||
Comment 43•5 years ago
|
||
bugherder |
Comment 44•5 years ago
|
||
Comment 45•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Reporter | ||
Comment 46•5 years ago
|
||
Comment 47•5 years ago
|
||
Comment 48•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Reporter | ||
Comment 49•5 years ago
|
||
Reporter | ||
Comment 50•5 years ago
|
||
Comment 51•5 years ago
|
||
Comment 52•5 years ago
|
||
bugherder |
Comment 53•5 years ago
|
||
uses the default config with rustfmt-stable
Comment 54•5 years ago
|
||
Comment 55•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Reporter | ||
Comment 56•5 years ago
|
||
Done with:
./mach lint -l rustfmt --fix
with
rustfmt 1.4.12-stable (a828ffe 2020-03-11)
ignore-this-changeset
Updated•5 years ago
|
Comment 57•5 years ago
|
||
Comment 58•5 years ago
|
||
bugherder |
Reporter | ||
Comment 59•5 years ago
|
||
Comment 60•5 years ago
|
||
Comment 61•5 years ago
|
||
bugherder |
Reporter | ||
Comment 62•5 years ago
|
||
Updated•5 years ago
|
Comment 63•5 years ago
|
||
Comment 64•5 years ago
|
||
bugherder |
Reporter | ||
Comment 65•5 years ago
|
||
ignore-this-changeset
Depends on D76451
Updated•5 years ago
|
Comment 66•5 years ago
|
||
Comment 67•5 years ago
|
||
bugherder |
Reporter | ||
Comment 68•5 years ago
|
||
# ignore-this-changeset
Depends on D76451
Comment 69•5 years ago
|
||
Comment 70•5 years ago
|
||
bugherder |
Reporter | ||
Comment 71•4 years ago
|
||
ignore-this-changeset
Depends on D77580
Comment 72•4 years ago
|
||
Comment 73•4 years ago
|
||
bugherder |
Reporter | ||
Comment 74•4 years ago
|
||
ignore-this-changeset
Comment 75•4 years ago
|
||
Comment 76•4 years ago
|
||
bugherder |
Reporter | ||
Comment 77•4 years ago
|
||
ignore-this-changeset
Depends on D79795
Comment 78•4 years ago
|
||
Comment 79•4 years ago
|
||
bugherder |
Reporter | ||
Comment 80•4 years ago
|
||
# ignore-this-changeset
Depends on D83258
Comment 81•4 years ago
|
||
Comment 82•4 years ago
|
||
bugherder |
Reporter | ||
Comment 83•4 years ago
|
||
ignore-this-changeset
Depends on D85678
Comment 84•4 years ago
|
||
Comment 85•4 years ago
|
||
bugherder |
Reporter | ||
Comment 86•4 years ago
|
||
ignore-this-changeset
Depends on D88713
Comment 87•4 years ago
|
||
Comment 88•4 years ago
|
||
bugherder |
Reporter | ||
Comment 89•4 years ago
|
||
ignore-this-changeset
Depends on D89392
Comment 90•4 years ago
|
||
Comment 91•4 years ago
|
||
bugherder |
Reporter | ||
Comment 92•4 years ago
|
||
ignore-this-changeset
Depends on D90793
Comment 93•4 years ago
|
||
Comment 94•4 years ago
|
||
bugherder |
Reporter | ||
Comment 95•4 years ago
|
||
ignore-this-changeset
Depends on D92459
Comment 96•4 years ago
|
||
Comment 97•4 years ago
|
||
bugherder |
Comment 98•4 years ago
|
||
Sylvestre, is there anything left to do here, or can the bug get closed?
Reporter | ||
Comment 99•4 years ago
|
||
Yeah, I am regularly refreshing the tree as it regresses.
So, keeping it until we have a better solution to update the tree.
Reporter | ||
Comment 100•4 years ago
|
||
# ignore-this-changeset
Depends on D95434
Comment 101•4 years ago
|
||
Comment 102•4 years ago
|
||
bugherder |
Reporter | ||
Comment 103•4 years ago
|
||
ignore-this-changeset
Depends on D96608
Comment 104•4 years ago
|
||
Comment 105•4 years ago
|
||
bugherder |
Reporter | ||
Comment 106•4 years ago
|
||
Updated•4 years ago
|
Reporter | ||
Comment 107•4 years ago
|
||
ignore-this-changeset
Depends on D90795
Comment 108•4 years ago
|
||
Comment 109•4 years ago
|
||
bugherder |
Reporter | ||
Comment 110•4 years ago
|
||
ignore-this-changeset
Depends on D98301
Comment 111•4 years ago
|
||
Comment 112•4 years ago
|
||
bugherder |
Reporter | ||
Comment 113•4 years ago
|
||
Updated with rustfmt 1.4.24-stable (eb894d5 2020-11-05)
ignore-this-changeset
Depends on D100230
Comment 114•4 years ago
|
||
Comment 115•4 years ago
|
||
bugherder |
Reporter | ||
Comment 116•4 years ago
|
||
Updated with rustfmt 1.4.25-stable (0f29ff6 2020-11-11)
ignore-this-changeset
Depends on D100934
Comment 117•4 years ago
|
||
Comment 118•4 years ago
|
||
bugherder |
Reporter | ||
Comment 119•4 years ago
|
||
Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)
ignore-this-changeset
Depends on D105158
Comment 120•4 years ago
|
||
Comment 121•4 years ago
|
||
bugherder |
Reporter | ||
Comment 122•4 years ago
|
||
Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)
ignore-this-changeset
Depends on D106920
Comment 123•4 years ago
|
||
Comment 124•4 years ago
|
||
bugherder |
Assignee | ||
Comment 125•4 years ago
|
||
Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)
# ignore-this-changeset
Depends on D113294
Updated•4 years ago
|
Comment 126•4 years ago
|
||
Comment 127•4 years ago
|
||
bugherder |
Assignee | ||
Comment 128•4 years ago
|
||
Initial reformat with rustfmt 1.4.36-stable (7de6968 2021-02-07)
Depends on D114211
Assignee | ||
Comment 129•4 years ago
|
||
Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)
Depends on D114211
Updated•4 years ago
|
Comment 130•4 years ago
|
||
Comment 131•4 years ago
|
||
bugherder |
Assignee | ||
Comment 132•4 years ago
|
||
Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)
Depends on D115804
Comment 133•4 years ago
|
||
Comment 134•4 years ago
|
||
bugherder |
Assignee | ||
Comment 135•3 years ago
|
||
Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)
Depends on D117905
Comment 136•3 years ago
|
||
Comment 137•3 years ago
|
||
bugherder |
Assignee | ||
Comment 138•3 years ago
|
||
Updated with rustfmt 1.4.37-stable (a178d03 2021-07-26)
Depends on D122814
Comment 139•3 years ago
|
||
Comment 140•3 years ago
|
||
bugherder |
Assignee | ||
Comment 141•3 years ago
|
||
Updated with rustfmt 1.4.37-stable (c8dfcfe 2021-09-06)
Depends on D129119
Comment 142•3 years ago
|
||
Comment 143•3 years ago
|
||
bugherder |
Assignee | ||
Comment 144•3 years ago
|
||
Updated with rustfmt 1.4.37-stable (f1edd04 2021-11-29)
Depends on D132868
Comment 145•3 years ago
|
||
Comment 146•3 years ago
|
||
bugherder |
Assignee | ||
Comment 147•3 years ago
|
||
Updated with rustfmt 1.4.37-stable (f1edd04 2021-11-29)
Depends on D135325
Assignee | ||
Comment 148•3 years ago
|
||
Updated with rustfmt 1.4.37-stable (f1edd04 2021-11-29)
Depends on D135325
Updated•3 years ago
|
Comment 149•3 years ago
|
||
Comment 150•3 years ago
|
||
Backed out for causing lint failures on multiple files
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/build/rust/dummy-web/js-sys/lib.rs:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
- Failure line 2: /builds/worker/checkouts/gecko/build/rust/dummy-web/js-sys/lib.rs:1 | Empty Lines at end of file (file-whitespace)
Reporter | ||
Comment 151•3 years ago
|
||
Andi pushed the patch, I didn't
Updated•3 years ago
|
Assignee | ||
Comment 152•3 years ago
|
||
Updated with rustfmt 1.4.38-stable (02072b4 2022-01-11)
Assignee | ||
Comment 153•3 years ago
|
||
Updated with rustfmt 1.4.38-stable (db9d1b2 2022-01-20)
Depends on D137147
Comment 154•3 years ago
|
||
Comment 155•3 years ago
|
||
bugherder |
Assignee | ||
Updated•3 years ago
|
Reporter | ||
Comment 156•2 years ago
|
||
ignore-this-changeset
Depends on D148375
Comment 157•2 years ago
|
||
Reporter | ||
Comment 158•2 years ago
|
||
Comment 159•2 years ago
|
||
Comment 160•2 years ago
|
||
bugherder |
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 161•2 years ago
|
||
Updated with rustfmt 1.4.38-stable (a8314ef 2022-06-27)
ignore-this-changeset
Depends on D151908
Updated•2 years ago
|
Comment 162•2 years ago
|
||
Comment 163•2 years ago
|
||
bugherder |
Assignee | ||
Comment 164•2 years ago
|
||
Updated with rustfmt 1.5.1-stable (4b91a6e 2022-08-08)
ignore-this-changeset
Depends on D154661
Comment 165•2 years ago
|
||
Comment 166•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 167•2 years ago
|
||
Updated with rustfmt 1.5.1-stable (897e375 2022-11-02)
ignore-this-changeset
Depends on D162815
Updated•2 years ago
|
Assignee | ||
Comment 168•2 years ago
|
||
Updated with rustfmt 1.5.1-stable (fc594f1 2023-01-24)
ignore-this-changeset
Depends on D168658
Updated•2 years ago
|
Comment 169•2 years ago
|
||
Comment 170•2 years ago
|
||
bugherder |
Assignee | ||
Comment 171•2 years ago
|
||
Updated with rustfmt 1.5.1-stable (2c8cc34 2023-03-06)
ignore-this-changeset
Comment 172•2 years ago
|
||
Comment 173•2 years ago
|
||
bugherder |
Assignee | ||
Comment 174•2 years ago
|
||
Updated with rustfmt 1.5.1-stable (9eb3afe 2023-03-27)
ignore-this-changeset
Comment 175•2 years ago
|
||
Comment 176•2 years ago
|
||
bugherder |
Assignee | ||
Comment 177•2 years ago
|
||
Updated with rustfmt 1.5.2-stable (84c898d 2023-04-16)
ignore-this-changeset
Depends on D176930
Assignee | ||
Comment 178•1 years ago
|
||
Updated with rustfmt 1.5.2-stable (90c5418 2023-05-31)
ignore-this-changeset
Depends on D180104
Updated•1 year ago
|
Updated•1 year ago
|
Description
•