Open Bug 1617369 Opened 5 years ago Updated 1 year ago

[rust] Reformat the tree using rustfmt

Categories

(Developer Infrastructure :: Lint and Formatting, task, P2)

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: Sylvestre, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: leave-open)

Attachments

(56 files, 11 obsolete files)

(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details

mach lint -l rustfmt --fix works well, it is enabled at review phase and we have tests in the CI. Let's see how to do it!

The patch is only 1.4M. As comparison, the move to the Google Coding style was 177M

Reformatting the whole tree takes less than ~15s

Attached file Bug 1617369 - Reformat the tree using rustfmt (obsolete) (deleted) —

ignore-this-changeset

Depends on D63758

Depends on D63955

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c624c72bb30f Reformat toolkit/crashreporter/ & toolkit/library/rust/ using rustfmt r=gsvelto
Keywords: leave-open
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f243a9acd63f Reformat testing/ using rustfmt r=whimboo,webdriver-reviewers
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93f12592ed0a Reformat js/ using rustfmt r=arai,bbouvier
Priority: -- → P2

Depends on D64869

Depends on D64870

Depends on D64871

Depends on D64873

Depends on D64874

Depends on D64875

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/810e31bf46f1 Reformat kvstore using rustfmt r=vporof

Depends on D64875

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f4da392a2fa Reformat libpref/ using rustfmt r=njn https://hg.mozilla.org/integration/autoland/rev/30451b2d1793 Rename C_HASH & C_CR to have the same length r=njn
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59d60966212e Reformat testing/ using rustfmt r=valentin
Attachment #9129970 - Attachment description: Bug 1617369 - Reformat storage/variant/ using rustfmt r?nija → Bug 1617369 - Reformat storage/variant/ using rustfmt r?nika
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1eadd6558fe3 Reformat bitsdownload/ using rustfmt r=valentin
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57557b6c13d5 Reformat storage/variant/ using rustfmt r=lina
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5155142c8a0 Reformat tools/profiler/rust-helper/ using rustfmt r=mstange
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/44221eabe5aa Reformat intl/ using rustfmt r=zbraniecki,hsivonen
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba1101a88a1f Reformat mozglue/ using rustfmt r=glandium
Blocks: rustfmt

Depends on D65897

Depends on D65901

Depends on D65902

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77be1b7956df Reformat netwerk/ using rustfmt r=agrover
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/337b6019e3d4 Reformat rsdparsa_capi/ using rustfmt r=dminor
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1695699198d4 Reformat webrender_bindings/ using rustfmt r=nical https://hg.mozilla.org/integration/autoland/rev/f08d49f7adf0 Reformat a rust test using rustfmt r=marco
Attachment #9128314 - Attachment is obsolete: true
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcde24b872ed Reformat recent rust changes r=webdriver-reviewers,whimboo
Attachment #9128315 - Attachment is obsolete: true
Attached file Bug 1617369 - Reformat wgpu/ using rustfmt r?kvark (obsolete) (deleted) —
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ed8741d48e2a Reformat intl/l10n/rust/fluent-ffi/ using rustfmt r=zbraniecki
Attached file Rustfmt pass over gfx/wgpu (deleted) —

uses the default config with rustfmt-stable

Attachment #9135372 - Attachment is obsolete: true

Done with:
./mach lint -l rustfmt --fix
with
rustfmt 1.4.12-stable (a828ffe 2020-03-11)

ignore-this-changeset

Depends on: 1633130
Attachment #9143348 - Attachment description: Bug 1617369 - Reformat recent rust changes with rustfmt r?bholley → Bug 1617369 - Reformat recent rust changes with rustfmt r?emilio
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08a0e1e4864c Reformat recent rust changes with rustfmt r=emilio
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a8437dd2b85 Reformat recent rust changes with rustfmt r=emilio
Attachment #9148264 - Attachment description: Bug 1617369 - Reformat recent rust changes with rustfmt r?kvark → Bug 1617369 - Reformat recent rust changes with rustfmt r?kvark DONTBUILD
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b6a16bd94fe Reformat recent rust changes with rustfmt r=kvark DONTBUILD

ignore-this-changeset

Depends on D76451

Attachment #9150990 - Attachment description: Bug 1617369 - Reformat recent rust changes with rustfmt r?emilio → Bug 1617369 - Reformat recent rust changes with rustfmt r?emilio DONTBUILD
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/171e43a075c2 Reformat recent rust changes with rustfmt r=emilio DONTBUILD

# ignore-this-changeset

Depends on D76451

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d2221f584b0f Reformat recent rust changes with rustfmt r=webdriver-reviewers,whimboo

ignore-this-changeset

Depends on D77580

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6eedccd860c3 Reformat recent rust changes with rustfmt r=froydnj

ignore-this-changeset

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63ce2e510b00 Reformat recent rust changes with rustfmt r=arai

ignore-this-changeset

Depends on D79795

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa0afb432810 Reformat recent rust changes with rustfmt r=emilio

# ignore-this-changeset

Depends on D83258

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b234115ff57e Reformat recent rust changes with rustfmt r=emilio

ignore-this-changeset

Depends on D85678

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dfcab23e3c1 Reformat recent rust changes with rustfmt r=emilio

ignore-this-changeset

Depends on D88713

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c5a72376017 Reformat recent rust changes with rustfmt r=emilio

ignore-this-changeset

Depends on D89392

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90bf9d8e0b52 Reformat recent rust changes with rustfmt r=emilio

ignore-this-changeset

Depends on D90793

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc4d17795322 Reformat recent rust changes with rustfmt r=emilio,necko-reviewers,valentin

ignore-this-changeset

Depends on D92459

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1449020ffc52 Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,necko-reviewers,dragana,whimboo

Sylvestre, is there anything left to do here, or can the bug get closed?

Flags: needinfo?(sledru)

Yeah, I am regularly refreshing the tree as it regresses.
So, keeping it until we have a better solution to update the tree.

Flags: needinfo?(sledru)

# ignore-this-changeset

Depends on D95434

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b76268bfeb60 Reformat recent rust changes with rustfmt r=emilio,necko-reviewers

ignore-this-changeset

Depends on D96608

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fa9c10eefd0 Reformat recent rust changes with rustfmt r=emilio
Attachment #9188282 - Attachment is obsolete: true

ignore-this-changeset

Depends on D90795

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b79688522892 Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,jgraham

ignore-this-changeset

Depends on D98301

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6aa458d78985 Reformat recent rust changes with rustfmt r=emilio DONTBUILD

Updated with rustfmt 1.4.24-stable (eb894d5 2020-11-05)

ignore-this-changeset

Depends on D100230

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32c9a04e95db Reformat recent rust changes with rustfmt r=emilio DONTBUILD

Updated with rustfmt 1.4.25-stable (0f29ff6 2020-11-11)

ignore-this-changeset

Depends on D100934

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/974cf1a79377 Reformat recent rust changes with rustfmt r=emilio

Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)

ignore-this-changeset

Depends on D105158

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea2cfbe4a0f4 Reformat recent rust changes with rustfmt r=emilio DONTBUILD

Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)

ignore-this-changeset

Depends on D106920

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7633e66d8199 Reformat recent rust changes with rustfmt r=emilio

Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)

# ignore-this-changeset

Depends on D113294

Attachment #9218259 - Attachment description: WIP: Bug 1617369 - Reformat recent rust changes with rustfmt. → Bug 1617369 - Reformat recent rust changes with rustfmt.
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72a8fb6cee5a Reformat recent rust changes with rustfmt. r=webdriver-reviewers,kvark

Initial reformat with rustfmt 1.4.36-stable (7de6968 2021-02-07)

Depends on D114211

Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)

Depends on D114211

Attachment #9220838 - Attachment is obsolete: true
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eaeaa4460a8d Reformat recent rust changes with rustfmt r=emilio,sylvestre

Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)

Depends on D115804

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/507717b6ecb0 Reformat recent rust changes with rustfmt r=emilio

Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)

Depends on D117905

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f5744deb718 Reformat recent rust changes with rustfmt r=necko-reviewers,webdriver-reviewers,kvark

Updated with rustfmt 1.4.37-stable (a178d03 2021-07-26)

Depends on D122814

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6188b58e6f84 Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,necko-reviewers,valentin

Updated with rustfmt 1.4.37-stable (c8dfcfe 2021-09-06)

Depends on D129119

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a7a2d1aa79e0 Reformat recent rust changes with rustfmt r=emilio,firefox-build-system-reviewers,mhentges

Updated with rustfmt 1.4.37-stable (f1edd04 2021-11-29)

Depends on D132868

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c48f8647b483 Reformat recent rust changes with rustfmt r=necko-reviewers,kershaw

Updated with rustfmt 1.4.37-stable (f1edd04 2021-11-29)

Depends on D135325

Updated with rustfmt 1.4.37-stable (f1edd04 2021-11-29)

Depends on D135325

Attachment #9257993 - Attachment is obsolete: true
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6726892a0012 Reformat recent rust changes with rustfmt r=emilio

Backed out for causing lint failures on multiple files

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/build/rust/dummy-web/js-sys/lib.rs:0 | No matching license strings found in tools/lint/license/valid-licenses.txt (license)
  • Failure line 2: /builds/worker/checkouts/gecko/build/rust/dummy-web/js-sys/lib.rs:1 | Empty Lines at end of file (file-whitespace)
Flags: needinfo?(sledru)

Andi pushed the patch, I didn't

Flags: needinfo?(sledru) → needinfo?(bpostelnicu)
Attachment #9258361 - Attachment is obsolete: true

Updated with rustfmt 1.4.38-stable (02072b4 2022-01-11)

Updated with rustfmt 1.4.38-stable (db9d1b2 2022-01-20)

Depends on D137147

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/843f8de11e22 Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers
Flags: needinfo?(bpostelnicu)

ignore-this-changeset

Depends on D148375

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69de1289762e Reformat recent rust changes with rustfmt r=emilio,extension-reviewers,willdurand
Pushed by bszekely@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/45d25b557e6c rust dummy: fix the linting warnings r=fix
Assignee: sledru → nobody

Updated with rustfmt 1.4.38-stable (a8314ef 2022-06-27)

ignore-this-changeset

Depends on D151908

Assignee: nobody → bpostelnicu
Status: NEW → ASSIGNED
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd9e234751a2 Reformat recent rust changes with rustfmt r=emilio

Updated with rustfmt 1.5.1-stable (4b91a6e 2022-08-08)

ignore-this-changeset

Depends on D154661

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8899f030ce1c Reformat recent rust changes with rustfmt r=emilio
Product: Firefox Build System → Developer Infrastructure
Severity: normal → S3

Updated with rustfmt 1.5.1-stable (897e375 2022-11-02)

ignore-this-changeset

Depends on D162815

Attachment #9304860 - Attachment is obsolete: true

Updated with rustfmt 1.5.1-stable (fc594f1 2023-01-24)

ignore-this-changeset

Depends on D168658

Attachment #9259078 - Attachment is obsolete: true
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9624ebc7fa89 Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,whimboo

Updated with rustfmt 1.5.1-stable (2c8cc34 2023-03-06)

ignore-this-changeset

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e8a915c37db Reformat recent rust changes with rustfmt r=emilio

Updated with rustfmt 1.5.1-stable (9eb3afe 2023-03-27)

ignore-this-changeset

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ab60f8b3c0a Reformat recent rust changes with rustfmt r=emilio

Updated with rustfmt 1.5.2-stable (84c898d 2023-04-16)

ignore-this-changeset

Depends on D176930

Updated with rustfmt 1.5.2-stable (90c5418 2023-05-31)

ignore-this-changeset

Depends on D180104

Attachment #9331188 - Attachment is obsolete: true
Attachment #9337705 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: