Closed
Bug 161740
Opened 22 years ago
Closed 21 years ago
Remove obsolete help files from builds
Categories
(SeaMonkey :: Help Documentation, defect, P3)
SeaMonkey
Help Documentation
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.6alpha
People
(Reporter: robinf, Assigned: rjkeller)
References
Details
Attachments
(3 files, 5 obsolete files)
(deleted),
application/x-zip-compressed
|
Details | |
(deleted),
patch
|
neil
:
review+
asa
:
approval1.6a+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
We want to remove obsolete help files from the builds to help reduce footprint.
Please add your current lists of files and images to this bug so Ian can
determine which ones have been obsoleted.
Nominating for next release.
Comment 2•22 years ago
|
||
These are obsolete HTML files in the help directory:
cs_nav_sidebar.html
prefs_help.html
ssl_page_info_help.html
Comment 3•22 years ago
|
||
Just checked _out_ the three filees listed here. Keeping bug open. Add 'em if
you got 'em.
Status: NEW → ASSIGNED
Comment 4•22 years ago
|
||
The ones Sean has mentioned covers Navigator's obsolete files.
You can safely delete these two obsolete image files:
anchor.gif
hrule.gif
Comment 6•22 years ago
|
||
Just deleted these two files and took them out of the build manifest. Keep 'em
coming!
Comment 7•22 years ago
|
||
Obsolete images:
bkmkmenu.gif
navbar.gif
navbuttons.gif
paperclip.gif
thread.gif
tagicon2.gif
taskbar_menus.gif
image5.gif is a duplicate of banner.gif.
image6.gif & image7.gif need to be updated to show the new modern theme instead
of modern1/2. not mention that they are used on the im help page, but mozilla
doesn't even have an im program...
Comment 8•22 years ago
|
||
Take a look at bug: 170125
Where I've put a small shell script that checks if a picture
file is used in the help or not.
Run against Mozilla 1.0.1 there where 25 unused .gif files
By the way if you want updated pictures to illustrate the help
(no the ones taken from Netscape 7), I've made some for the French
version (just ask for them), many pictures could also be shrunk
by reducing their color use (most of the time they look as good
using only 64 colors, or even less, instead of 256).
http://bugzilla.mozilla.org/show_bug.cgi?id=170125
Comment 9•22 years ago
|
||
Drop-in replacement (picture size based on Mozilla 1.0.1)
Comment 10•22 years ago
|
||
These are just a few samples, I could taylor you new ones on demand.
Comment 11•22 years ago
|
||
possibly im_help.html (there is no IM in Mozilla)
Comment 12•22 years ago
|
||
im_help.html obsolete
images/image6.gif ?obsolete? de-netscape-ize
images/image7.gif ?obsolete? de-netscape-ize
images/image8.gif ?obsolete? de-netscape-ize
images/image9.gif obsolete
images/taskbar.gif de-netscape-ize
images/mailicon.gif de-netscape-ize
images/newmail.gif de-netscape-ize
images/composer_icon.gif de-netscape-ize
images/taskbar-ab.gif de-netscape-ize
images/taskbar-aim-online.gif obsolete
images/imtaskbar.gif obsolete
images/taskbar_menus.gif obsolete
images/navbar.gif ?obsolete?
images/navbuttons.gif ?obsolete?
images/personalbar.gif de-netscape-ize
images/searchmusic.gif de-netscape-ize
images/sidebarclosed_small.gif de-netscape-ize
Blocks: 112271
Target Milestone: mozilla1.2alpha → mozilla1.3beta
Comment 13•22 years ago
|
||
*** Bug 152715 has been marked as a duplicate of this bug. ***
Comment 14•22 years ago
|
||
*** Bug 170125 has been marked as a duplicate of this bug. ***
Comment 15•22 years ago
|
||
contents & photoshop files also avail here
http://www.geocities.com/stolenclover/backstage/moz-temp/help-images/
old file name new file name? comment
im_help.html -remove- obsolete
image6.gif -remove- not used
image7.gif -remove- not used
image8.gif -remove- not used
image9.gif -remove- not used
taskbar-aim-online.gif -remove- not used
imtaskbar.gif -remove- not used
taskbar_menus.gif -remove- not used
online.gif --- denetscapify
offline.gif --- denetscapify
taskbar.gif --- denetscapify
Navigator
history-session.gif new
history-typed-urls.gif new
locationbar.gif --- denetscapify
search.gif search-locationbar.gif denetscapify
searchmusic.gif search-sidebar.gif denetscapify
navbar.gif -remove- not used
navbuttons.gif -remove- not used
personalbar.gif --- denetscapify
search_personal_toolbar.gif -remove- should be removed
tabbed_browsing_bar.gif --- denetscapify
sidebarclosed_small.gif --- denetscapify
Mail
flag.gif mail_flag.gif denetscapify
flag_column.gif mail_flag_column.gif denetscapify
read_column.gif mail_read_column.gif denetscapify
newmail.gif task_newmail.gif denetscapify
mailicon.gif task_mail.gif denetscapify
newmailicon.gif mail_newmail_alert.gif denetscapify
threadbutton.gif --- denetscapify
thread.gif --- denetscapify
columns.gif --- denetscapify
Composer
numbers.gif composer_numbers.gif denetscapify
bullets.gif composer_bullets.gif denetscapify
link.gif composer_link.gif denetscapify
image.gif composer_image.gif denetscapify
table.gif composer_table.gif denetscapify
composer_icon.gif task_composer denetscapify
Customize
personaltoolbar.gif --- denetscapify
Address book
taskbar-ab.gif task_ab.gif denetscapify
Attachment #100193 -
Attachment is obsolete: true
Attachment #100194 -
Attachment is obsolete: true
Comment 16•21 years ago
|
||
moving stuff over to an outside-the-firewall email for the time being, looking
for people to pick these Help and doc bugs up for me.
Assignee: oeschger → oeschger
Status: ASSIGNED → NEW
Assignee | ||
Comment 17•21 years ago
|
||
--> me
This will be fixed for 1.6a (since the help menu is being rewritten).
Assignee: oeschger → rlk
Severity: normal → minor
Target Milestone: mozilla1.3beta → mozilla1.6alpha
Assignee | ||
Comment 18•21 years ago
|
||
Daniel, Is your image data still valid? If so, I'll see about fixing this.
Status: NEW → ASSIGNED
Comment 19•21 years ago
|
||
I think they are. however, I gave all the images a blue tint because I thought
colors might be too distracting. I now don't think they are a good idea, so I
might have to re-redo the images from
http://www.geocities.com/stolenclover/backstage/moz-temp/help-images/photoshop_files.zip
Assignee | ||
Comment 20•21 years ago
|
||
Daniel: well, if the obsolete image list is accurate, then I might be able to
give a patch to remove them from the build.
As for denetscapeing the images, if you have a computer that has access to
Windows XP, you can use the Windows XP classic theme, that's not very
distracting. You might be able to try a Linux KDE or GNOME theme that will
change the background of the classic theme to make it less distracting.
This problem is related to bug 219418 about denetscapeifying some of the images.
Blocks: 219418
Comment 21•21 years ago
|
||
these can be checked in
note there are two new images: history-session.gif and history-typed-urls.gif
that I think you should incorporate into browser Help.
the task_*.gif images are slightly manipulated
Attachment #121127 -
Attachment is obsolete: true
Assignee | ||
Comment 22•21 years ago
|
||
Looks good. Are these images designed to replace the old help images? If so,
some appear to be missing (but they may be obsolete, not sure).
Comment 23•21 years ago
|
||
I'mm not sure if gif-images are still 'ugh',
but if they are, shouldn't png-encoding applied?
Updated•21 years ago
|
QA Contact: tpreston → stolenclover
Assignee | ||
Comment 24•21 years ago
|
||
Attachment #131864 -
Attachment is obsolete: true
Assignee | ||
Comment 25•21 years ago
|
||
Comment on attachment 132275 [details] [diff] [review]
Patch 2.01
bah. wrong bug. sorry for the spam!
Attachment #132275 -
Attachment is obsolete: true
Comment 26•21 years ago
|
||
update to comment 15: personaltoolbar.gif is not used. remove.
Comment 27•21 years ago
|
||
*** Bug 211651 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 28•21 years ago
|
||
Comment on attachment 133533 [details]
png version images - 1st run
Daniel, is it safe to assume that this will replace ALL of the images in
mozilla/extensions/help/resources/locale/en-US/images?
Attachment #133533 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 29•21 years ago
|
||
Comment on attachment 133533 [details]
png version images - 1st run
No. this zip only deals with those needing update. Let's quicken the process by
incremental updates
Attachment #133533 -
Attachment description: png version images → png version images - 1st run
Comment 30•21 years ago
|
||
Comment on attachment 133533 [details]
png version images - 1st run
OK, so switching to classic theme looks good, although I'm not convinced about
the background colour. Also, those taskbar images, you've greyscaled and tinted
them, right? Instead of tinting the "active" button, why not restore the
non-greyscaled version?
Assignee | ||
Comment 31•21 years ago
|
||
Removes unused files from jar.mn. LXR returned no results (other than jar.mn)
for all of the images removed.
Assignee | ||
Updated•21 years ago
|
Attachment #134087 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•21 years ago
|
Attachment #134087 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Updated•21 years ago
|
Attachment #134087 -
Flags: approval1.6a?
Comment 32•21 years ago
|
||
Comment on attachment 134087 [details] [diff] [review]
Remove obsolete files from jar.mn
a=asa (on behalf of drivers) for checkin to 1.6alpha
Attachment #134087 -
Flags: approval1.6a? → approval1.6a+
Assignee | ||
Comment 33•21 years ago
|
||
Fix checked in. Let's move the new images to bug 107225 (not sure why they're
here in the first place).
Unlike what oeschger said, I'd prefer to close this bug now.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 34•21 years ago
|
||
Removes some more obsolete files I found.
Assignee | ||
Updated•21 years ago
|
Attachment #135228 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•21 years ago
|
Attachment #135228 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Comment 35•21 years ago
|
||
Patch checked in.
Comment 37•21 years ago
|
||
Comment on attachment 133533 [details]
png version images - 1st run
Removing obsolete request; these images seem to be dealt with (and have r=) in
bug 107225.
Attachment #133533 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•