Closed Bug 1617472 Opened 5 years ago Closed 5 years ago

Remove CSS keyword tables and such.

Categories

(Core :: CSS Parsing and Computation, task)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(7 files, 2 obsolete files)

Bug 1617472 - Minor cleanup of image layers. r=#style
(deleted), text/x-phabricator-request
Details
Bug 1617472 - Remove kFontSmoothingKTable. r=#style
(deleted), text/x-phabricator-request
Details
Bug 1617472 - Use enums for text-align / text-align-last. r=#style,jfkthame
(deleted), text/x-phabricator-request
Details
Bug 1617472 - Remove kTextAlignKTable. r=#style
(deleted), text/x-phabricator-request
Details
Bug 1617472 - Remove kTextDecorationStyleKTable. r=#style
(deleted), text/x-phabricator-request
Details
Bug 1617472 - Remove nsCSSKeywords and related infrastructure. r=#style
(deleted), text/x-phabricator-request
Details
Bug 1617472 - Put Servo_GetPropertyValue behind a method in ComputedStyle. r=heycam
(deleted), text/x-phabricator-request
Details
No description provided.

Remove some unused enums and some single-call function that also caused a copy
of two LengthPercentage values.

This is pretty drive-by, could be a different bug.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

Use the more general mechanism to get a property value. We can't just remove
the getter because of the resist-fingerprinting check, but...

Depends on D63791

This also fixes some backwards logic in nsBlockFrame::ReflowDirtyLines, and adds
some static assertions to nsGenericHTMLElement that almost cause a very subtle
bug.

Depends on D63792

Depends on D63793

In a somewhat easy way. There are better ways to do this (moving
text-decoration-style to be a proper cbindgen enum class or such), but this
does the job for now.

Depends on D63794

Seeya

Depends on D63795

Attached file Bug 1617472 - Minor cleanup of image layers. r=#style (obsolete) (deleted) —

Remove some unused enums and some single-call function that also caused a copy
of two LengthPercentage values.

This is pretty drive-by, could be a different bug.

Attached file Bug 1617472 - Remove kFontSmoothingKTable. r=#style (obsolete) (deleted) —

Use the more general mechanism to get a property value. We can't just remove
the getter because of the resist-fingerprinting check, but...

Depends on D63797

Attachment #9128394 - Attachment is obsolete: true
Attachment #9128395 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f817fa67b51f Minor cleanup of image layers. r=heycam https://hg.mozilla.org/integration/autoland/rev/17061d1394b7 Remove kFontSmoothingKTable. r=heycam https://hg.mozilla.org/integration/autoland/rev/400b7003dd40 Use enums for text-align / text-align-last. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/3d90d2bf476b Remove kTextAlignKTable. r=heycam https://hg.mozilla.org/integration/autoland/rev/ad22c10d9fbe Remove kTextDecorationStyleKTable. r=heycam https://hg.mozilla.org/integration/autoland/rev/2827d9d7168e Remove nsCSSKeywords and related infrastructure. r=heycam
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ab6bc11f5a9 Put Servo_GetPropertyValue behind a method in ComputedStyle. r=heycam
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: