Open Bug 1617555 Opened 5 years ago Updated 2 years ago

No way to immediately reflect the Dark/Light theme switch to panel's icon

Categories

(WebExtensions :: Developer Tools, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: arai, Unassigned)

References

(Depends on 1 open bug)

Details

devtools.panels.create [1] receives the path to icon, that is shown in the panel's tab,
the icon can be specified only when creating the panel, and cannot be changed later.

Then, you can switch the DevTools' theme in Settings panel, and the change is immediately
reflected to the UI, leaving extensions' panel icons as is.

devtools.panels.onThemeChanged [2] provides a way to detect the theme switch, but with lack of the way to change the icon on already-created panel, the there's no way to reflect the theme change to the icon.

this is problematic if the extensions follows the current icon style (monotone icon),
given light-theme icon on dark-theme (or vice versa) is almost invisible.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/devtools.panels/create
[2] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/devtools.panels/onThemeChanged

Bug 1617554 is related, that the way to reflect the theme change to icon that built-in panels are using doesn't work for extension's panel.

So, currently, the only way to reflect the theme switch to extension's icon is to close the DevTools and reopen it.

Depends on: 1618580
Flags: needinfo?(lgreco)

Clearing needinfo, I replied to the related needinfo on Bug 1618580 (Bug 1618580 Comment 2).

Flags: needinfo?(lgreco)

The priority flag is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mixedpuppy)
Priority: -- → P3
Flags: needinfo?(mixedpuppy)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.