Closed Bug 1618268 Opened 5 years ago Closed 5 years ago

Wrong context menu is displayed when right click on the website's link while in Edit mode

Categories

(Firefox :: about:logins, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 75
Tracking Status
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- verified

People

(Reporter: cmuntean, Assigned: mcrawford)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image edit mode.gif (deleted) —

[Affected Versions]:

  • Nightly 75.0a1
  • Beta 74.0b7
  • Firefox 73.0.1

[Affected Platforms]

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]

  • Have a Firefox profile with multiple logins saved.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Navigate to "about:logins" page.
  3. Select any saved login from the login list.
  4. Click the "Edit" button.
  5. Right click on the website's link.
  6. Observe the opened context menu.

[Expected results]:

  • The context menu with the "open/copy link" options is displayed.

[Actual results]:

  • The context menu with the "Undo/Cut/Paste/Delete" options is displayed.

[Notes]:

  • It seems that the link displayed in "Edit" mode has a different format than the link displayed in the Login item.
  • Attached a screen recording with the issue.

Looks like maybe the wrong element is used in this mode. Maxx, do you want to take this follow-up?

Blocks: 1578736
Flags: needinfo?(mcrawford)
Priority: -- → P3

Sigh... yeah we should only be showing the input in create mode, not edit mode.

Assignee: nobody → mcrawford
Status: NEW → ASSIGNED
Flags: needinfo?(mcrawford)

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #1)

Looks like maybe the wrong element is used in this mode. Maxx, do you want to take this follow-up?

Sure can. Self-assigning now.

Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6bf07b88ab96 Only toggle the origin input when editing a new login item r=jaws

Comment on attachment 9130281 [details]
Bug 1618268 - Trigger Sync CFR when a non-FxA user updates a saved password from doorhanger r?MattN

Revision D65034 was moved to bug 1615685. Setting attachment 9130281 [details] to obsolete.

Attachment #9130281 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75

I have verified this issue and is no longer reproducible in "Edit" mode. Tested on the latest Nightly 75.0a1 build (Build ID: 20200303095030) on Windows 10 x64, Mac 10.14 and Arch Linux.

  • The correct context menu is displayed when clicking on the website's link displayed in "Edit" mode.
  • The options from the context menu work as expected.
  • The link is no longer opened if clicking on the empty area beside the website on Login item.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: