mozdevice unit tests fail if `adb features` lists more than cmd and shell_v2
Categories
(Testing :: Mozbase Rust, defect, P3)
Tracking
(firefox76 fixed)
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: barret, Assigned: barret, Mentored)
Details
(Whiteboard: [lang=rust])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The unit test for feature detection checks that the set of features provided by adb is exactly cmd and shell_v2. If any other features are present, the test fails.
Ideally, we should be checking that the returned set of features contains the subset {shell_v2, cmd} instead.
|
||
Comment 1•5 years ago
|
||
Are you running it against a real device or which version of the emulator?
|
Assignee | |
Comment 2•5 years ago
|
||
I am running this against a real device (Pixel 4 XL). Testing against a Moto G5 works fine.
|
|
||
Comment 3•5 years ago
|
||
Yeah, that would explain it. When I wrote those tests the reference was the Android emulator which is what we mostly run in CI for non-performance tests.
So yes, checking for a subset of features in the following test sounds fine to me:
https://searchfox.org/mozilla-central/rev/49ed791eec93335abfe6c2880f84c324e73e47e6/testing/mozbase/rust/mozdevice/src/test.rs#98-107
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D65174
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•