[rel=preload] Update `image::imgLoader` to use `PreloaderBase` and `Document.PreloadService`
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: mayhemer, Assigned: edgar)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
Part of Design documentation for rel=preload
Please follow this “image” type design.
This depends on the PreloaderBase class being implemented. The idea is to let the image load handler (imgRequest) derive from it and let the loader register it in Document.PreloadService.
Other part is to kick the preload as speculative load from inside the HTML5 parser for images.
Note that the image loader will never be called more than once to start a speculative load, neither preload or regular, so there is no need to add any more coalescing than we already have in the HTML5 parser (the caller to the loader) and the image loader itself. The image cache is the internal loader coalescing mechanism and we use it to link speculative loads and actual loads. This will not be changed.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
Depends on D68786
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
Depends on D68786
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Reporter | ||
Comment 5•5 years ago
|
||
(In reply to Edgar Chen [:edgar] from comment #4)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=79f96395bcfaab890e12b5f9c99a19c348f57b02
There will be a lot of failures from the surrounding preload changes too. I'm right now working on cleaning the crashes up along with rebasing of the patches + incorporating your latest patch too. Edit: no, just everything before with preload disabled (at current default).
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
See https://html.spec.whatwg.org/multipage/semantics.html#the-link-element:attr-link-imagesrcset.
Depends on D71949
Comment 8•4 years ago
|
||
I filed bug 1635599 for the existing issue with MaybePreLoadImage and IsImageInCache.
Comment 10•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/13350bb8d726
https://hg.mozilla.org/mozilla-central/rev/9ea0dc474630
https://hg.mozilla.org/mozilla-central/rev/91163f65e128
Description
•