Closed
Bug 1618516
Opened 5 years ago
Closed 5 years ago
Fix remaining uses of is/as<JSScript>()
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is a follow-up to Bug 1615143. GCCellPtr doesn't distinguish between LazyScript/JSScript so use is<BaseScript>() instead. These fixes are benign, but are footguns worth fixing.
|
Assignee | |
Comment 1•5 years ago
|
||
These checks only check the trace-kind is BaseScript. Fix the code to refer
to these types directly to avoid confusion.
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41f66cfd20dc
Fix remaining uses of is/as<JSScript>(). r=jandem
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•