Closed
Bug 161865
Opened 22 years ago
Closed 22 years ago
GetFieldID shouldn't INSERT into the fielddefs table
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bbaetz, Assigned: bbaetz)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bugreport
:
review+
bugreport
:
review+
|
Details | Diff | Splinter Review |
This has been bothering me for a while.
GetFieldID has the interesting habit of inserting entries if it can't find them.
This leads to bugs like bug 157505, plus another similar one we had recently
which I can't seem to find. This is also caueing problems when I try to work out
where an extra entry is coming from in my patch for bug 43600.
I've got a patch which converts this into a die (not a template error, since
this could come from anywhere really) and adds fielddefs which aren't in
checksetup.pl to the list to be created there.
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
-> me
|
||
Comment 3•22 years ago
|
||
Comment on attachment 94607 [details] [diff] [review]
patch
r= by Joel
Checked original source of this insert and it dates back to the original
addition of the fielddefs table before checksetup knew what to do with it.
Attachment #94607 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•