Closed Bug 1618691 Opened 5 years ago Closed 5 years ago

Start using the tab descriptor in about:debugging

Categories

(DevTools :: about:debugging, task, P3)

task

Tracking

(firefox77 fixed)

RESOLVED FIXED
Firefox 77
Tracking Status
firefox77 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 2 open bugs)

Details

(Whiteboard: devtools-backward-compat)

Attachments

(6 files, 1 obsolete file)

Follow up to Bug 1579042.

Now that we can have tab descriptors, we should start using descriptors instead of targets in about:debugging. As a first step we can start relying on the descriptor's form to build the UI and ultimately we can just skip getting the targets completely (and only get them when opening the toolbox)

Summary: Start using the tab descriptor form in about:debugging → Start using the tab descriptor in about:debugging
Depends on: 1620194
Blocks: 1618788

Depends on D65398

Blocks: 1624722
Blocks: 1618698
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Blocks: 1600612

Depends on D65398

Attachment #9137510 - Attachment description: Bug 1618691 - Use tab descriptor in about:debugging → Bug 1618691 - Use tab descriptor in about:debugging (TabDescriptorMock WIP)
Depends on: 1626875

Depends on D69543
There are no actual call sites for selected, but we have a test checking the feature.
Alternatively we could get rid of the feature.

Depends on D69544
Since selected is read on the descriptor form, there is no need to include it in the listTabs response.

Blocks: 1627270
Blocks: 1628254
Blocks: 1628259

Depends on D65693

Blocks: 1628325
Blocks: 1627912
Attachment #9137510 - Attachment is obsolete: true
Whiteboard: [devtools-backward-compat]
Whiteboard: [devtools-backward-compat] → devtools-backward-compat
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb99b5f24bfe Remove < FF75 backward compatibility code for getProcess r=ochameau https://hg.mozilla.org/integration/autoland/rev/57c00207e4bc Remove < FF75 backward compatibility code for getTab and listTabs r=ochameau https://hg.mozilla.org/integration/autoland/rev/e3025878bda1 Return selected as property of the TabDescriptorActor form r=ochameau https://hg.mozilla.org/integration/autoland/rev/3f8d60253ea9 Stop returning selected tab information in listTabs r=ochameau https://hg.mozilla.org/integration/autoland/rev/25435d091261 Use tab descriptor in about:debugging r=ochameau https://hg.mozilla.org/integration/autoland/rev/c9502ace44dc Simplify RootActor::listTabs response r=ochameau

:jdescottes hey, one of the patches related to this bug breaks our web-ext tool. We documented the issue in our tracker here: https://github.com/mozilla/web-ext/issues/1884, could you please take a look and help us find a more suitable way to retrieve the addonsActor? Thanks!

Flags: needinfo?(jdescottes)

replied on the GH issue!

Flags: needinfo?(jdescottes)
Regressions: 1631012
Regressions: 1631463
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: