Open
Bug 1618863
Opened 5 years ago
Updated 2 years ago
Page.navigate doesn't fail for status code other than 200 (eg. 204 - no content)
Categories
(Remote Protocol :: CDP, defect, P2)
Remote Protocol
CDP
Tracking
(Not tracked)
NEW
People
(Reporter: whimboo, Unassigned)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [puppeteer-beta2-mvp])
As we are currently aware of Page.navigate returns too early (bug 1603776) because it doesn't wait for the response package (bug 1599257). So it is not aware of possible failed requests like a 204 status code.
That means that the returned result doesn't contain an error like in Chrome:
puppeteer:protocol ◀ RECV {"id":18,"result":{"frameId":"3D1D462A15E159199DC0E8B98B4F093C","loaderId":"053D582A5655467C188F62493C4E9390","errorText":"net::ERR_ABORTED"},"sessionId":"8DDF85656E125DCB1290760405A1D463"} +1ms
|
Reporter | |
Comment 1•5 years ago
|
||
The failure can be reproduced with:
https://searchfox.org/mozilla-central/rev/b2ccce862ef38d0d150fcac2b597f7f20091a0c7/remote/test/puppeteer/test/page.spec.js#97-108
|
|
Reporter | |
Comment 2•5 years ago
|
||
Also this is related to all the puppeteer tests which make use of a pattern like:
page.goto(...).catch(e => error = e);
Except navigation timeouts we seem to not return any kind of error right now.
|
|
Reporter | |
Updated•5 years ago
|
Priority: P3 → P2
Whiteboard: [puppeteer-beta-reserve]
|
|
Reporter | |
Updated•4 years ago
|
Whiteboard: [puppeteer-beta-reserve] → [puppeteer-beta2-mvp]
|
Assignee | |
Updated•4 years ago
|
Component: CDP: Page → CDP
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•