Closed Bug 1618938 Opened 5 years ago Closed 5 years ago

[macOS] Menulists in the prefs are not tall enough

Categories

(Firefox :: Settings UI, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 75
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 --- unaffected
firefox75 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Today in "no good deed goes unpunished" - I regressed this in bug 1616008 because I missed the macOS-only rule at https://searchfox.org/mozilla-central/rev/a3266997560904b484fd89d6a6bcdeace4a13652/toolkit/themes/osx/global/menulist.css#15 , which takes precedence over the menulist rule in the prefs, so it sets min-height to 20px instead of 30px.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

The :not() clause unhelpfully influences the specificity of the selector for menulists in general.
However, it is not necessary anyway, because xul.css overrides the min-height to 0 for [popuponly]
menulists using !important.

Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Flags: qe-verify+

Can you please point me to a menulist where this change can be seen with the naked eye? I failed to notice any changes (post fix build - after fix build) after taking a look at some menus inside about:preferences.

Flags: needinfo?(gijskruitbosch+bugs)
Attached image Screenshot from 2020-02-29 build (deleted) —

This is a screenshot from mozregression --launch 2020-02-29.

Attached image Screenshot from more recent nightly (deleted) —

And this is one from a more recent nightly. As you can see, the dropdown menus' heights now match that of the "advanced" button, and didn't in the "broken" build.

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(bogdan.maris)

Thanks Gijs for the info. I could see the defect using old NIghtly from 2020-02-29. Verified that the dropdown lists like the one from Fonts, Zoom, Home, Search and others now respect the min-height of 30px on 75.0b7-build1 macOS 10.15.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(bogdan.maris)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: