Closed Bug 1619455 Opened 5 years ago Closed 5 years ago

Kill GC/CC timers on content-child-will-shutdown

Categories

(Core :: DOM: Content Processes, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

When content-child-will-shutdown gets signalled, we've begun to shut down the content process. We should kill the GC timers when this happens to avoid shutdown hangs in child processes. I don't know how much it will help in practice.

Basically this just requires tweaking nsJSEnvironmentObserver to listen for content-child-will-shutdown and add that topic to the section of Observer() that handles quit-application. Then test it and hope it doesn't cause other issues.

Assignee: nobody → continuation

Hopefully this will reduce the number of shutdown hangs in child processes.

Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c56290d76bef Kill GC/CC timers on content-child-will-shutdown. r=smaug
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

It looks like maybe this has reduced the number of shutdown hangs where a GC is ongoing. Also, I looked at some GC shutdown hangs before and after this landed, and I saw some with an IPC shutdown state before, but not after.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: