Closed
Bug 1619664
Opened 5 years ago
Closed 5 years ago
Allow to toggle widget.disable-native-theme-for-content without restarting
Categories
(Core :: Widget, task)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
It is just so annoying :)
|
Assignee | |
Comment 1•5 years ago
|
||
The boxes can just poke at the prescontext theme like literally everything else.
|
|
Assignee | |
Comment 2•5 years ago
|
||
This allows testing much more easily.
There are some edge cases with native theme changes and such (ThemeChanged and
co assume there's only one theme per process). But I don't think they matter
much for our use cases.
Depends on D65161
|
|
Assignee | |
Comment 3•5 years ago
|
||
There were some callers in nsRangeFrame that were already not-null-checking.
All platforms have a native theme and should we add new ones they could use
nsBasicNativeTheme.
Depends on D65162
|
||
Updated•5 years ago
|
Attachment #9130516 -
Attachment description: Bug 1619664 - Rename nsPresContext::GetTheme as it can't return null. r=dholbert → Bug 1619664 - Rename and don't null-check nsPresContext::GetTheme as it can't return null. r=dholbert
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4532abf9270b
Remove nsBox::gTheme. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/c1e88fa43e7e
Decide which theme to use per document, not per-process. r=mstange,spohl
https://hg.mozilla.org/integration/autoland/rev/ebafc021b885
Rename and don't null-check nsPresContext::GetTheme as it can't return null. r=dholbert
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4532abf9270b
https://hg.mozilla.org/mozilla-central/rev/c1e88fa43e7e
https://hg.mozilla.org/mozilla-central/rev/ebafc021b885
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•