Closed
Bug 1619796
Opened 5 years ago
Closed 5 years ago
Don't fire `onLoadRequest()` for loads initiated via `GeckoSession.loadUri()`.
Categories
(GeckoView :: General, defect, P1)
Tracking
(Performance Impact:high, firefox76 fixed)
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: snorp, Assigned: agi)
References
(Blocks 2 open bugs)
Details
(Keywords: perf:pageload, Whiteboard: [geckoview:m76])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The app commanded the load, so we don't need to ask them again. This hurts us a lot on applink perf because the UI thread is very busy doing other startupy things. This profile[1] shows onLoadRequest() taking 450ms, which is pretty brutal.
|
||
Updated•5 years ago
|
Whiteboard: [qf] → [qf:p1:pageload]
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → agi
|
||
Updated•5 years ago
|
Priority: -- → P1
Whiteboard: [qf:p1:pageload] → [qf:p1:pageload][geckoview:m76]
|
||
Comment 1•5 years ago
|
||
Bug 1621676 has numbers that justify giving this a very high priority.
Blocks: 1621676
|
|
Assignee | |
Comment 2•5 years ago
|
||
This is already a P1 and scheduled for this sprint (i.e. the highest priority)
|
Reporter | |
Updated•5 years ago
|
Blocks: GeckoView_Startup
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9cec62a163b
Don't fire onLoadRequest for embedder-initiated loads. r=smaug,droeh
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
|
||
Updated•3 years ago
|
Performance Impact: --- → P1
Keywords: perf:pageload
Whiteboard: [qf:p1:pageload][geckoview:m76] → [geckoview:m76]
You need to log in
before you can comment on or make changes to this bug.
Description
•