Closed
Bug 1619910
Opened 5 years ago
Closed 5 years ago
Cover upgrades from indexedDB/ and storage/persistent/ directory by QM_FIRST_INITIALIZATION_ATTEMPT telemetry
Categories
(Core :: Storage: Quota Manager, task, P2)
Core
Storage: Quota Manager
Tracking
()
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: janv, Assigned: tt)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/plain
|
chutten
:
data-review+
|
Details |
We need to add two new keys:
UpgradeFromIndexedDBDirectory for MaybeUpgradeFromIndexedDBDirectoryToPersistentStorageDirectory()
UpgradeFromPersistentStorageDirectory for MaybeUpgradeFromPersistentStorageDirectoryToDefaultStorageDirectory()
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → ttung
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Attachment #9131013 -
Attachment description: Bug 1619910 - Collect the success rates of upgrades from indexedDB/ and storage/persistent/ directory; → Bug 1619910 - P2 - Collect the success rates of upgrades from indexedDB/ and storage/persistent/ directory;
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
try with making two functions fail on debug builds when expected directories is files: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3b7cdaaf4967040037729beb955b22b40f19126
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Attachment #9132556 -
Flags: data-review?(chutten)
Comment 7•5 years ago
|
||
Comment on attachment 9132556 [details]
request-bug1619910.md
DATA COLLECTION REVIEW RESPONSE:
Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.
If the request is for permanent data collection, is there someone who will monitor the data over time?
Yes, :tt is responsible.
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 1, Technical.
Is the data collection request for default-on or default-off?
Default on for all channels.
Does the instrumentation include the addition of any new identifiers?
No.
Is the data collection covered by the existing Firefox privacy notice?
Yes.
Does there need to be a check-in in the future to determine whether to renew the data?
No. This collection is permanent.
---
Result: datareview+
Attachment #9132556 -
Flags: data-review?(chutten) → data-review+
Pushed by ttung@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49dc6f34f29a
P1 - Change MaybeUpgradeFrom* to UpgradeFrom*; r=janv,dom-workers-and-storage-reviewers
https://hg.mozilla.org/integration/autoland/rev/7968baec19c9
P2 - Collect the success rates of upgrades from indexedDB/ and storage/persistent/ directory; r=janv,dom-workers-and-storage-reviewers
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/49dc6f34f29a
https://hg.mozilla.org/mozilla-central/rev/7968baec19c9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•