Closed Bug 1619978 Opened 5 years ago Closed 5 years ago

Crash sometimes if we fail to get the SystemFontCollection

Categories

(Core :: Graphics: Text, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

WebRender won't support GDI fonts so we need to figure out what to do with the users that are currently using them. This should help give us better diagnostics on what's going wrong.

WebRender won't support GDI fonts so we need to figure out what to do
with the users that are currently using them. This should help give us
better diagnostics on what's going wrong.

gfxCriticalError only crashes on Nightly and Beta builds

Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7980da78f422 Crash sometimes if we fail to get the SystemFontCollection. r=jfkthame
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

This crash doesn't seem to be getting hit and we're still getting failures https://sql.telemetry.mozilla.org/queries/69184/source

Blocks: 1509155

I wonder if Factory::GetDWriteSystemFonts is returning null. If we leave out the possibility that the factory itself failed to initialize for now, and assume it is non-null, then the remaining possibility, however unlikely, would be that mDWriteFactory->GetSystemFontCollection() is returning success and a null font collection at the same time. Maybe it's worth adding a check for null systemFonts and see what we can catch...

Attachment #9150958 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: