Can't access all items in drop down list of device sizes
Categories
(DevTools :: Responsive Design Mode, defect, P1)
Tracking
(firefox-esr68 unaffected, firefox74 unaffected, firefox75 wontfix, firefox76 wontfix, firefox77 wontfix, firefox78 verified)
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox74 | --- | unaffected |
firefox75 | --- | wontfix |
firefox76 | --- | wontfix |
firefox77 | --- | wontfix |
firefox78 | --- | verified |
People
(Reporter: shobson, Assigned: daisuke)
References
(Regressed 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(4 files, 1 obsolete file)
Thank you for helping make Firefox better. If you are reporting a defect, please complete the following:
What were you doing?
Using Responsive Design Mode and the HTML inspector docked to the bottom of my screen on a laptop. In Nightly.
- Open RDM
- Open HTML Inspector
- Make HTML Inspector really tall
- Try to change the device in the RDM device drop down
What happened?
I can only access items at the bottom of the drop down.
What should have happened?
Probably I should be able to scroll the list if it doesn't all fit in the available space?
Comment 1•5 years ago
|
||
Daisuke, I think you worked on the dropdown menu recently. Would you know the cause for this? Thanks!
Assignee | ||
Comment 2•5 years ago
|
||
Thank you for letting me know!
I also could reproduce this.
I suppose the reason is that we started to use HTML for the menu instead of XUL.
I will take a look.
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9131403 [details]
Bug 1620098: Change the container of the popup in order to use XUL element.
Hello Gabriel and Micah!
As I commented, the reason why the tooltip can't overlay the inspector pane is because of using HTML for the menu.
Thus, in order to overlay, it seems we can do if we use XUL element and prepare a place where holds the element outside of the responsive document.
I made a prototype with the above thinking and upload the patch.
Could you give your opinion about whether this approach is good or not?
Assignee | ||
Comment 5•5 years ago
|
||
Ah, I did not apply the style yet for the prototype.
Comment 6•5 years ago
|
||
Comment on attachment 9131403 [details]
Bug 1620098: Change the container of the popup in order to use XUL element.
I am gonna also request feedback from Julian since he also has a bit more context on this with the work he has done with HTMLTooltips.
Comment 7•5 years ago
|
||
Thanks for the ping!
I think we can simplify the approach, added a comment in the diff.
Daisuke, did you notice that if you:
- open the menu
- click on the menu button again
The menu disappears and re-appears immediately, at the moment it simply closes.
Comment 8•5 years ago
|
||
Comment on attachment 9131403 [details]
Bug 1620098: Change the container of the popup in order to use XUL element.
f+ if we can handle this by changing the isXUL logic.
Assignee | ||
Comment 9•5 years ago
|
||
Thank you very much for your feedback and helpful advice always, Julian!
I'll take a look and fix the behavior and the isXUL logic!
Comment 10•5 years ago
|
||
Comment on attachment 9131403 [details]
Bug 1620098: Change the container of the popup in order to use XUL element.
I think we're in good hands here after bgrins and jdescottes took a look through it so I will remove the feedback for myself.
Comment 11•5 years ago
|
||
The priority flag is not set for this bug.
:gl, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Assignee | ||
Comment 13•5 years ago
|
||
Assignee | ||
Comment 14•5 years ago
|
||
Depends on D67983
Updated•5 years ago
|
Assignee | ||
Comment 15•5 years ago
|
||
Depends on D67984
Comment 16•5 years ago
|
||
Copying flags over from bug 1624361
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 18•5 years ago
|
||
Hi Daisuke, are you still actively working on this one?
Assignee | ||
Comment 19•5 years ago
|
||
Hi Rachel!
Yes, I am. However, as this bug is dependent on bug 1629770, I'm waiting until fixing that.
Comment 20•5 years ago
|
||
Comment 21•5 years ago
|
||
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=301139091&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/e392e4a34033d5b594da33bdbf207119bdd5af54
[task 2020-05-07T02:34:15.893Z] PASS components/badge.test.js
[task 2020-05-07T02:34:15.893Z] Badge component:
[task 2020-05-07T02:34:15.893Z] ✓ basic render (29ms)
[task 2020-05-07T02:34:15.893Z]
[task 2020-05-07T02:34:15.893Z] Test Suites: 2 failed, 12 passed, 14 total
[task 2020-05-07T02:34:15.893Z] Tests: 11 failed, 40 passed, 51 total
[task 2020-05-07T02:34:15.893Z] Snapshots: 48 passed, 48 total
[task 2020-05-07T02:34:15.893Z] Time: 13.17s
[task 2020-05-07T02:34:15.893Z] Ran all test suites.
[task 2020-05-07T02:34:15.893Z] error Command failed with exit code 1.
[task 2020-05-07T02:34:15.893Z]
[task 2020-05-07T02:34:15.893Z] [devtools-node-test-runner] Parse errors from the test logs
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityTreeFilter component: › audit filter not filtered
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityTreeFilter component: › audit filters filtered
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityTreeFilter component: › audit all filter not filtered auditing
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityTreeFilter component: › audit other filter not filtered auditing
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityTreeFilter component: › audit all filter filtered auditing
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityTreeFilter component: › audit other filter filtered auditing
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityTreeFilter component: › toggle filter
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityTreeFilter component: › render filters after state changes
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityPrefs component: › prefs not set by default
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityPrefs component: › prefs checked
[task 2020-05-07T02:34:15.893Z] TEST-UNEXPECTED-FAIL | jest | accessibility | ● AccessibilityPrefs component: › toggle pref
[task 2020-05-07T02:34:15.893Z] [devtools-node-test-runner] Test suite [accessibility] failed
[task 2020-05-07T02:34:15.893Z] [devtools-node-test-runner] You can find documentation about the devtools node tests at https://docs.firefox-dev.tools/tests/node-tests.html
[task 2020-05-07T02:34:15.893Z] ules/react-dom/cjs/react-dom.development.js:17258:5)
[task 2020-05-07T02:34:15.893Z] at Object.render (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/react-dom/cjs/react-dom.development.js:17317:12)
[task 2020-05-07T02:34:15.894Z] at render (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:429:26)
[task 2020-05-07T02:34:15.894Z] at fn (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:343:12)
[task 2020-05-07T02:34:15.894Z] at Object.wrapAct [as render] (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/enzyme-adapter-react-16/src/ReactSixteenAdapter.js:415:16)
[task 2020-05-07T02:34:15.894Z] at new render (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/enzyme/src/ReactWrapper.js:115:16)
[task 2020-05-07T02:34:15.894Z] at mount (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/enzyme/src/mount.js:10:10)
[task 2020-05-07T02:34:15.894Z] at Object.mount (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/components/accessibility-tree-filter.test.js:245:21)
[task 2020-05-07T02:34:15.894Z] at Object.asyncJestTest (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
[task 2020-05-07T02:34:15.894Z] at resolve (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
[task 2020-05-07T02:34:15.894Z] at new Promise (<anonymous>)
[task 2020-05-07T02:34:15.894Z] at mapper (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
[task 2020-05-07T02:34:15.894Z] at promise.then (/builds/worker/checkouts/gecko/devtools/client/accessibility/test/node/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
[task 2020-05-07T02:34:15.894Z] at process._tickCallback (internal/process/next_tick.js:68:7)
[task 2020-05-07T02:34:15.894Z]
[task 2020-05-07T02:34:15.894Z] console.error node_modules/react-dom/cjs/react-dom.development.js:14226
Comment 22•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 23•5 years ago
|
||
Comment 24•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4c1410654ab7
https://hg.mozilla.org/mozilla-central/rev/fea2b74b3352
https://hg.mozilla.org/mozilla-central/rev/bd70a801f80c
Comment 26•5 years ago
|
||
The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•5 years ago
|
Updated•4 years ago
|
Comment 27•4 years ago
|
||
Reproduced the issue using Firefox 75.0a1 (20200304161940) on Windows 10x64.
The issue is verified fixed with Firefox 78.0b7 (20200612174529) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.
Description
•