Closed Bug 1620113 Opened 5 years ago Closed 5 years ago

update main controller to the last tab playing media

Categories

(Core :: Audio/Video: Playback, defect, P1)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Regression)

Details

(Keywords: regression)

Attachments

(7 files)

Bug 1620113 - part1 : support `contain` and `length` for LinkedList.
(deleted), text/x-phabricator-request
Details
Bug 1620113 - part2 : replace nsTArray with LinkedList.
(deleted), text/x-phabricator-request
Details
Bug 1620113 - part3 : rename function names to explicitly mention that they're used for main controller.
(deleted), text/x-phabricator-request
Details
Bug 1620113 - part4 : update main controller when controller changes its playback state to playing.
(deleted), text/x-phabricator-request
Details
Bug 1620113 - part5 : add test.
(deleted), text/x-phabricator-request
Details
Bug 1620113 - part6 : modify test.
(deleted), text/x-phabricator-request
Details
Bug 1620113 - part7 : revert the workaround in 'browser_media_control_stop_timer.js'.
(deleted), text/x-phabricator-request
Details

Since bug1571493, we are able to control media even if we pause it from website directly, not from the media control keys. But it causes another problem which is we lost tracking the last tab playing media, so we should fix this issue in order to always let media control keys to control the last tab playing media.

STR.

  1. playing media in tab A
  2. playing media in another tab B
  3. pause media in tab A by directly controlling media from page
  4. start media in tabA again by directly controlling media from page
  5. press media control key

Expect.
6. tab A should be controlled

Actual.
6. We are controlling tab B, not tab A

Bugbug thinks this bug is a defect, but please change it back in case of error.

Type: task → defect
Attached file Bug 1620113 - part5 : add test. (deleted) —

Target this bug on this release cycle (Fx76) so mark it as P1.

Severity: normal → minor
Priority: P3 → P1
Attached file Bug 1620113 - part6 : modify test. (deleted) —
Blocks: 1623486
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2511ace99c5e part1 : support `contain` and `length` for LinkedList. r=froydnj https://hg.mozilla.org/integration/autoland/rev/d3f1873dfae9 part2 : replace nsTArray with LinkedList. r=chunmin https://hg.mozilla.org/integration/autoland/rev/1185f5a8daf8 part3 : rename function names to explicitly mention that they're used for main controller. r=chunmin https://hg.mozilla.org/integration/autoland/rev/5241e4aab772 part4 : update main controller when controller changes its playback state to playing. r=chunmin https://hg.mozilla.org/integration/autoland/rev/d17830bcc177 part5 : add test. r=chunmin https://hg.mozilla.org/integration/autoland/rev/3d865b06d46d part6 : modify test. r=chunmin https://hg.mozilla.org/integration/autoland/rev/827124686e24 part7 : revert the workaround in 'browser_media_control_stop_timer.js'. r=chunmin
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: