Closed Bug 1620137 Opened 5 years ago Closed 5 years ago

Small Input in Password Required Pop-up

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect)

75 Branch
defect
Not set
normal

Tracking

(firefox-esr68 unaffected, firefox73 unaffected, firefox74 unaffected, firefox75+ verified)

VERIFIED FIXED
mozilla75
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 --- unaffected
firefox75 + verified

People

(Reporter: eros_uk, Assigned: ntim)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image Password Required Pop-up.jpg (deleted) —

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

In the last 2 updates (both applied one after the other so I don't know which one is the reason), the input field in Password Required Pop-up has shrunk per attached screenshot.

Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Ever confirmed: true
Keywords: regression
Regressed by: 1606617
Component: Untriaged → Notifications and Alerts
Product: Firefox → Toolkit
Flags: needinfo?(ntim.bugs)

[Tracking Requested - why for this release]:
User-visible regression in dialog boxes

I expect the box's container needs moz-box-align: stretch or something.

Need to test this on my windows machine.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to :Gijs (he/him) from comment #5)

Need to test this on my windows machine.

I tried, but I can't verify that this helps because even if I back out the regressing bug I don't see wrapping text in the testcase in the regressing bug.

Alice, can you check if the trypush at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c13828023a9ded8c30c7879f867ca4e6e6172afb reintroduces bug 1606617 for you?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(alice0775)

(In reply to :Gijs (he/him) from comment #6)

(In reply to :Gijs (he/him) from comment #5)

Need to test this on my windows machine.

I tried, but I can't verify that this helps because even if I back out the regressing bug I don't see wrapping text in the testcase in the regressing bug.

Alice, can you check if the trypush at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c13828023a9ded8c30c7879f867ca4e6e6172afb reintroduces bug 1606617 for you

This bug is fixed on the try-build.
However, Bug 1606617 is back on the try-build. Descriptions and buttons overlap each other.

Flags: needinfo?(alice0775)
Attachment #9131099 - Attachment description: Bug 1620137 - Make #dialogGrid take its parent width. → Bug 1620137 - Make #dialogGrid wrapper a <div> instead of a <box>.
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED

(In reply to Tim Nguyen :ntim from comment #8)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3934eba8139f55d77d2b603b18745d51355de56e

This bug and Bug 1606617(overlap issue) are fixed on the try-build.
However, the button cut off issue is back...

Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1fc93d698058 Make #dialogGrid wrapper a <div> instead of a <box>. r=Gijs

(In reply to Alice0775 White from comment #9)

(In reply to Tim Nguyen :ntim from comment #8)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3934eba8139f55d77d2b603b18745d51355de56e

This bug and Bug 1606617(overlap issue) are fixed on the try-build.
However, the button cut off issue is back...

Thanks for testing! I filed bug 1620575 to address the cut-off, since this is unfortunately tricky to fix.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Flags: qe-verify+

I'm not able to reproduce the issue on Windows 7 x64 and Windows 10 x64 using Firefox Nightly 75.0a1 (2020-03-04).

Can you please verify that the issue is fixed in the latest Beta build? You can download the Beta build from the following link: https://archive.mozilla.org/pub/firefox/candidates/75.0b6-candidates/build1/

Thanks!

Flags: qe-verify+
Flags: needinfo?(eros_uk)
Flags: needinfo?(alice0775)

I can not reproduce on 75.0b4 as well as Nightly76.0a1(20200320095353) windows10.

Flags: needinfo?(alice0775)

AFA I recall it was fixed. I am currently on 76.0a1 (2020-03-19) (64-bit)

Flags: needinfo?(eros_uk)
Status: RESOLVED → VERIFIED

Thanks, Alice & erosman!

Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: