Closed Bug 1620185 Opened 5 years ago Closed 5 years ago

Get rid of Kinto offline client

Categories

(Firefox :: Remote Settings Client, enhancement, P1)

Product:
Firefox
Component:
Remote Settings Client
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: leplatrem, Assigned: leplatrem)

References

(Blocks 1 open bug)

Details

Attachments

(12 files)

Bug 1620185 - Replace .sync() by underlying calls r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Replace pullMetadata() with low level code r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Reuse code from signature failure retry r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Remove usage of kinto.js collection methods r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Remove usage of kinto.js collection instance r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Remove usage of .openCollection() r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Remove usage of .openCollection() in other modules r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Simplify CanonicalJSON of records r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Move DB to separate file r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Import IndexedDB code from kinto.js r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Improve behaviour when signature is bad after retry r?glasserc
(deleted), text/x-phabricator-request
Details
Bug 1620185 - Fetch metadata and records in parallel r?glasserc
(deleted), text/x-phabricator-request
Details

Currently, the kinto.js library is used for the following aspects:

  • Some abstraction over IndexedDB
  • A single call to a .sync() method with some hooks for signature validation
  • Some small helpers to manipulate local data

But its relevance is limited:

  • We only pull from a read-only server
  • The pulling of records is duplicated in the retry sync part
  • The logic in the signature verification hook is duplicated for the retry sync part
  • Some the IndexedDB code is duplicated in the Web worker part

Basically, getting rid of kinto.js would globally mean moving the IDB abstraction part into a small module.

Blocks: 1620186

Depends on D66411

Depends on D66630

You sai

Priority: P3 → P1
Assignee: nobody → mathieu
Attachment #9132590 - Attachment description: Bug 1620185 - Replace .sync() by underlying calls → Bug 1620185 - Replace .sync() by underlying calls r?glasserc
Status: NEW → ASSIGNED
Attachment #9132593 - Attachment description: Bug 1620185 - Replace pullMetadata() with low level code → Bug 1620185 - Replace pullMetadata() with low level code r?glasserc
Attachment #9132594 - Attachment description: Bug 1620185 - Reuse code from signature failure retry → Bug 1620185 - Reuse code from signature failure retry r?glasserc
Attachment #9132970 - Attachment description: Bug 1620185 - Remove usage of kinto.js collection methods → Bug 1620185 - Remove usage of kinto.js collection methods r?glasserc
Attachment #9132971 - Attachment description: Bug 1620185 - Remove usage of kinto.js collection instance → Bug 1620185 - Remove usage of kinto.js collection instance r?glasserc
Attachment #9132973 - Attachment description: Bug 1620185 - Remove usage of .openCollection() → Bug 1620185 - Remove usage of .openCollection() r?glasserc

Depends on D66749

Depends on D66750

Depends on D66751

When the signature verification fails after retry we don't want to apply the changes, and if possible we want to leave the local data as it was before sync.

Depends on D66752

Depends on D67139

Pushed by mleplatre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb8b759f04d9 Replace .sync() by underlying calls r=glasserc https://hg.mozilla.org/integration/autoland/rev/7fd588e36c00 Replace pullMetadata() with low level code r=glasserc https://hg.mozilla.org/integration/autoland/rev/39ec37b67db8 Reuse code from signature failure retry r=glasserc https://hg.mozilla.org/integration/autoland/rev/c87605a73bfd Remove usage of kinto.js collection methods r=glasserc https://hg.mozilla.org/integration/autoland/rev/94e4e16672a7 Remove usage of kinto.js collection instance r=glasserc https://hg.mozilla.org/integration/autoland/rev/11cd85d6ece7 Remove usage of .openCollection() r=glasserc https://hg.mozilla.org/integration/autoland/rev/c37c85b90377 Remove usage of .openCollection() in other modules r=glasserc https://hg.mozilla.org/integration/autoland/rev/08d4f7f88ddb Simplify CanonicalJSON of records r=glasserc https://hg.mozilla.org/integration/autoland/rev/ee83a9baacc0 Move DB to separate file r=glasserc https://hg.mozilla.org/integration/autoland/rev/be13c324f376 Import IndexedDB code from kinto.js r=glasserc https://hg.mozilla.org/integration/autoland/rev/5218a697618d Improve behaviour when signature is bad after retry r=glasserc https://hg.mozilla.org/integration/autoland/rev/9c1e03c2f350 Fetch metadata and records in parallel r=glasserc
Regressions: 1623229
Regressions: 1624301
Blocks: 1637465
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: