Implement console message listening via the ResourceWatcher API on the actor side
Categories
(DevTools :: Framework, enhancement, P2)
Tracking
(Fission Milestone:M6c, firefox79 fixed)
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 5 open bugs)
Details
(Whiteboard: dt-fission-m2-mvp)
Attachments
(3 files, 8 obsolete files)
While bug 1576624 implement a 100% client side version of the Resources API,
which demonstrates that it would work against old Firefox versions.
This bug will focus on implementing this on the actor side.
Implementing it on the actor side would allow:
- To get rid of the quite complex
LegacyImplementations
pieces of code introduced in bug 1576624, once this bug reaches Firefox release channel. - In coordination to bug 1593937, this will allow listening to resources before the document, process or worker would start executing anything.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6) milestone
Assignee | ||
Comment 4•5 years ago
|
||
This bug will be the first case of server side listening of a resource, applied to console messages.
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Comment 7•5 years ago
|
||
Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)
Assignee | ||
Comment 8•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 9•5 years ago
|
||
This would probably better match a potential followup where we are using
BrowsingContext attributes/events dedicated to DevTools instead of sharedData.
Assignee | ||
Comment 10•5 years ago
|
||
This is to workaround races when reading/writting sharedData from multiple callsites in the same process.
Assignee | ||
Comment 11•5 years ago
|
||
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Comment on attachment 9149846 [details]
Bug 1620243 - Instantiate only one ResourceWatcher in the console stubs test.
Revision D75790 was moved to bug 1640641. Setting attachment 9149846 [details] to obsolete.
Comment 13•5 years ago
|
||
Comment on attachment 9151440 [details]
Bug 1620243 - Add resourceType
attribute to each resource and emit list of resources.
Revision D76672 was moved to bug 1640641. Setting attachment 9151440 [details] to obsolete.
Assignee | ||
Comment 14•5 years ago
|
||
Assignee | ||
Comment 15•4 years ago
|
||
I broke logpoints again:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=addc79a6c31a289d9edc56af1133355288a32b42
But if we ignore that, try is green with the latest changes.
Assignee | ||
Comment 16•4 years ago
|
||
Assignee | ||
Comment 17•4 years ago
|
||
Assignee | ||
Comment 18•4 years ago
|
||
DAMP reports no very significant change.
May be a small improvement on console.expand test:
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&newRevision=8fd81d533f24a31395af47083bd3b786db5984e0&originalSignature=1910071&newSignature=1910071&framework=12&originalRevision=689429e8c00efba18fe6ce0bf0588c92c820140b
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 19•4 years ago
|
||
This is an alternative to how I addressed this issue:
https://phabricator.services.mozilla.com/D77441?id=290263#inline-451203
We pass the list of watched resources from the parent process, when calling WatcherActor.watchTargets, instead of relying on sharedData.
So that, sharedData is really only read when the document starts loading, from DevToolsFrameChild.instantiate.
i.e. only where we really have to depend on sharedData.
If you are happy with this patch, I'll merge it into the previous one.
Updated•4 years ago
|
Assignee | ||
Comment 20•4 years ago
|
||
Comment 21•4 years ago
|
||
Comment 22•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/18c4fee3723c
https://hg.mozilla.org/mozilla-central/rev/6700501368b1
https://hg.mozilla.org/mozilla-central/rev/12624e4520a1
Description
•