Making the cursor blink causes too much activity in the browser console
Categories
(DevTools :: Console, enhancement, P3)
Tracking
(firefox76 fixed)
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: florian, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The cursor of the browser console blinks using JS code and a setInterval timer. https://searchfox.org/mozilla-central/rev/c79c0d65a183d9d38676855f455a5c6a7f7dadd3/devtools/client/shared/sourceeditor/codemirror/lib/codemirror.js#3264
This causes more activity than needed, which is visible in profiles: https://perfht.ml/2IiHuQ6
For comparison, here's a profile of the cursor blinking in the url bar: https://perfht.ml/2TpApnb
|
Assignee | |
Comment 1•5 years ago
|
||
CodeMirror sets a setInterval function in which the cursor element
visibility is toggled on and off. This shows up in profiles, and on
slow hardware or busy situations, this can make the editor feel slow.
This patch sets the cursorBlinkingRate to 0, which won't trigger the
setInterval setup, and reimplement the blinking through CSS animation.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Blinking cursors can be blinding and can trigger migraines. Please ensure that if users set ui.caretBlinkTime to 0 on our own, you don't override this and hurt us again.
|
|
||
Updated•5 years ago
|
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•