Closed
Bug 1620482
Opened 5 years ago
Closed 5 years ago
Don't treat non-user-triggered autofill into login forms as an edit for capture
Categories
(Toolkit :: Password Manager, defect, P1)
Toolkit
Password Manager
Tracking
()
VERIFIED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | verified disabled |
| firefox76 | --- | verified |
People
(Reporter: sfoster, Assigned: sfoster)
References
Details
(Whiteboard: [passwords:capture-UI])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
When signon.passwordEditCapture.enabled is true, autofilling a form with a saved login results in a PasswordEditedOrGenerated message being sent to the parent process. This is wrong in a couple of ways:
- The form is flagged as user-modified, so bypasses the measures implemented in bug 1388674 in this case.
- LoginManagerParent gets the message and has to determine if a doorhanger should be shown. This is invisible to the user but messes up a lot of tests...
- The dispatch of the PasswordEditedOrGenerated breaks an assumption in a lot of tests that FormProcessed will happen first, resulting in intermittent failure.
|
Assignee | |
Comment 1•5 years ago
|
||
- Dont flag a form as user-modified when the input is from autofilling a login
- Avoid sending PasswordEditedOrGenerated messages to the parent from non-user-modified forms.
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aaedc7cf346b
Don't treat non-user-triggered autofill into login forms as an edit. r=MattN
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
|
||
Comment 4•5 years ago
|
||
Verified-fixed for Firefox Beta 75.0b9 (after setting signon.passwordEditCapture.enabled to true) and on Latest Nightly 76.0a1 (2020-03-26) on Windows 10, Mac OS 10.13 and Ubuntu 16.04.
Autofilled credentials on login forms are not recorded as an edit for capture -> the dismissed doorhanger is not displayed.
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•