Closed Bug 1621337 Opened 5 years ago Closed 5 years ago

Expose Service Workers for tab targets in the TargetList

Categories

(DevTools :: Debugger, enhancement, P2)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(Fission Milestone:M6c, firefox78 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 78
Project Flags:
Fission Milestone M6c
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: ochameau, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(3 files, 6 obsolete files)

Bug 1621337 - Check if existingTargets is still defined when processing listWorkerChanged
(deleted), text/x-phabricator-request
Details
Bug 1621337 - Add support for service workers in target-list
(deleted), text/x-phabricator-request
Details
Bug 1621337 - Add an option to workers listener to only listen to sw registrations
(deleted), text/x-phabricator-request
Details

Bug 1594754 started exposing service workers when the TargetList was attached to a Parent Process Targets. i.e. the browser toolbox codepath.
But with the windowless service worker features, the Debugger panel expects to also be able to retrieve the service workers of the page that the content toolbox is debugging.
We would need to tweak the TargetList once again in order to enable to notify about the service worker targets related to the page, that, behind a preference as it has some significant impact on the performance.

Priority: -- → P2
Whiteboard: dt-fission-m2-mvp

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6
Attached file Bug 1621337 - wip service worker registrations (obsolete) (deleted) —
Blocks: 1626655

Note that the immediate goal is to unlock the debugger to use the TargetList for all its targets (bug 1626655).
So we probably don't have to expose all what RootFront.listAllWorkers currently exposes.

Blocks: 1621338
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Depends on D73803

Depends on D74057

Depends on D74059

Depends on D74699

Depends on D74701

Only for reference, this might not land

Attachment #9146182 - Attachment is obsolete: true
Attachment #9146183 - Attachment is obsolete: true
Attachment #9146185 - Attachment is obsolete: true
Attachment #9146188 - Attachment is obsolete: true

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Fission Milestone: M6 → M6c
No longer blocks: 1621338
Blocks: 1638394
Blocks: 1638756
Attachment #9147341 - Attachment description: Bug 1621337 - Use a dedicated target list for service workers in debugger → Bug 1621337 - Enable service worker target listening in the debugger
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6dc7f0528d29 Check if existingTargets is still defined when processing listWorkerChanged r=ochameau https://hg.mozilla.org/integration/autoland/rev/0680f7d982e1 Add an option to workers listener to only listen to sw registrations r=ochameau https://hg.mozilla.org/integration/autoland/rev/1b9b798b261e Add support for service workers in target-list r=ochameau

https://hg.mozilla.org/mozilla-central/rev/6dc7f0528d29
https://hg.mozilla.org/mozilla-central/rev/0680f7d982e1
https://hg.mozilla.org/mozilla-central/rev/1b9b798b261e

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Attachment #9147341 - Attachment is obsolete: true
Attachment #9137187 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: