Closed Bug 1621521 Opened 5 years ago Closed 5 years ago

Make xpcAccessible::GetDeepestChildAtPoint walk into remote child documents

Categories

(Core :: Disability Access APIs, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

Details

Attachments

(1 file)

Currently, it stops at an OuterDocAccessible. It will need to walk into that and continue the search.

Yura, is this going to break the Dev Tools A11y Panel? The crash worked around in bug 1568163 suggests the A11y Panel might ask for this when running within the Browser Toolbox. With the change proposed here, instead of stopping at the OuterDoc (XUL browser), it will return a ProxyAccessible within a remote document.

If this is problematic, we could just make the tests hit test on the root (which will return the OuterDoc), then hit test on the returned OuterDoc.

Flags: needinfo?(yzenevich)

It might be currently, though I think with fission it might be OK since we are relying on DOM events to trigger the code that runs getDeepestChildAtPoint in the right process.

Flags: needinfo?(yzenevich)

Previously, it stopped at an OuterDocAccessible.
Now, if an OuterDocAccessible is encountered, it continues the search in the remote child document.

As part of this, the bulk of the code has been moved into AccessibleOrProxy, since other callers might find this useful in future.

Assignee: nobody → jteh
Status: NEW → ASSIGNED
Attachment #9132790 - Attachment description: Bug 1621521: Make xpcAccessible::GetDeepestChildAtPoint walk into remote child documents. → Bug 1621521: Make xpcAccessible::Get(Deepest)ChildAtPoint walk into remote child documents.
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51fa8835f5d8 Make xpcAccessible::Get(Deepest)ChildAtPoint walk into remote child documents. r=yzen
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: