See https://phabricator.services.mozilla.com/D66513#inline-395604 where Emilio points out the null-check of aRequest is not needed.

Hello,
I am a beginner at open source contributions. I was reading somewhere and eventually landing on this page where it says this is a good first bug to work on. But I am not getting any idea with how to get started with solving this bug. Where can I find the code base?
Can you please help me get started with this?

Hey, sure!

You can read https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction for a quick overview. To build the code you can follow the instructions at: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build.

Once that's done, you can explore the codebase in https://searchfox.org. The related code is here:

https://searchfox.org/mozilla-central/rev/7d0c94a0e9a9fe1f83553f49b10128567d21709d/layout/generic/nsBulletFrame.cpp#1109

The if (!aRequest) line is completely unneeded, because it can never be null. It should either be removed or replaced by a MOZ_ASSERT(aRequest).

You can join https://chat.mozilla.org/#/room/#introduction:mozilla.org for more questions / more people to answer those, or ask on the bug the same way and I'll try to help :)

Hey,
Is this bug still available, I would like to try and fix it.

Yes, please go ahead!

Depends on D68021

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Hey it seems this bug is still available. Can I work on this?

Thanks
Tanweer

Sure, please go ahead :)

Hi Emilio,

Is this bug open to be picked up.

Thanks,
Murali

Hello achmurali, Sorry to let you know I am working on this bug right now.

Hey emilio,

This method has already been removed. Check this https://hg.mozilla.org/mozilla-central/comparison/66d167aa16ea7d1293095c863ed953de59b89df7/layout/generic/nsBulletFrame.cpp

So I guess this bug need to be close.

Thanks,
Tanweer Ali

Ahh, good catch, this was indeed fixed (by removing the relevant code) in bug 1685078