Open Bug 1621894 Opened 5 years ago Updated 2 years ago

investigate RootActor#removeActorByName

Categories

(DevTools :: Framework, task, P3)

task

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

In this function (devtools/server/actors/root.js#734-740 ), we iterate over this._tabDescriptorActorPool children, and call their removeActorByName.

The issue is that removeActorByName is a BrowsingContextTargetActor, and the children in _tabDescriptorActorPool should be TabDescriptors (devtools/server/actors/descriptors/tab.js#39) which don't have such method.

So if this is called, this is probably throwing.

Priority: -- → P3

So, this function is called from

for (const connID of Object.getOwnPropertyNames(this._connections)) {  // this._connections is an empty object here

so what's inside the loop isn't called, and we don't see the underlying issue (calling a method that does not exist on tab descriptors)


it also appears to be called from

but I'm not sure if/how this is used from the client, I need to investigate a bit more

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.