Closed Bug 1622665 Opened 5 years ago Closed 4 years ago

ActorsParent.cpp: redundant access specifier has the same accessibility as the previous access specifier

Categories

(Developer Infrastructure :: Source Code Analysis, task)

task
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Sylvestre, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

+++ This bug was initially created as a clone of Bug #1622663 +++

Filling as a good first bug to learn workflows.

protected:
  const bool mClear;

 protected:
  ClearRequestBase(bool aExclusive, bool aClear)
      : QuotaRequestBase(aExclusive), mClear(aClear) {

redundant access specifier has the same accessibility as the previous access specifier
here, protected is declared twice

https://searchfox.org/mozilla-central/source/dom/quota/ActorsParent.cpp#1589-1593

As the change is trivial, it is just to learn how to contribute to Firefox.

http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-access-specifiers.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

This change appears to be done, no fix necessary?

Flags: needinfo?(sledru)

Indeed, please let me know if you want another bug!
Thanks

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(sledru)
Resolution: --- → FIXED

Yes please, was looking for a first bug to get into contributing, however, was having issues with OAuth in phabricator, any ideas on how to resolve this?

Thanks

Dunno and bugzilla isn't the best place for this ;)
Maybe bug 1622662 ?
or bug 1622660
bug 1629419

Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.